pull review state bug

[6543]

gitea: v1.21, v1.20, ... and older

reproduce: ( task | actor)

1. pull to protected branch to USER_A | USER_B
2. request review of USER_A | USER_B
3. Review (ack/rej) | USER_A
4. Push to pull change | USER_B
5. Dismiss review | USER_A

-> review request can not be deleted
-> if "dismis stale reviews" is set, step 5. is not needed and gitea break it itself

[6543]

gitea/models/issues/review.go

Line 463 in 6a725b6

has, err := db.GetEngine(ctx).SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_id = ? AND original_author_id = 0 AND type in (?, ?, ?))",

gitea/models/issues/review.go

Line 482 in 6a725b6

if has, err = db.GetEngine(ctx).SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_team_id = ?)",

can we just use the xorm builder !!!!!!!

[github-actions]

Automatically locked because of our CONTRIBUTING guidelines