Error when pushing to renamed repository

[lafriks]

Description

When pushing to/pulling from renamed repository there is error:

git fetch
error: RPC failed; HTTP 307 curl 22 The requested URL returned error: 307
fatal: expected flush after ref listing

Gitea Version

1.21.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Binary

Database

PostgreSQL

[lunny]

Did you push to the old name or the new name?

[PsychotherapistSam]

Hi, same issue here: When pushing to the old URL of a repo that has been moved (in my case from a user to an org), I get the same error. Setting the new remote URL works, of course.

[lafriks]

When pushing to the old remote url, also by just renaming without changing owner

[lunny]

What's the expectation? Should it be allowed to redirect to the real repository or should it return the 404?

[chris-08154711]

Same here. Seems like the 1.21.2 update (or previous) broke the redirect functionality for renamed repos or organization or when moving a repo from one orga to another.

Before it was possible to rename/move a repo/orga and still use (fetch, pull, push) the local copy without having to "fix" the remote url. Gitea redirected from the previous remote url to the new location/name automatically.
There was a warning on the console that the operation is executed on a redirected URL.

Please fix! Its a pita to rename an organization with certain number of repos and users without this feature!

[lafriks]

What's the expectation? Should it be allowed to redirect to the real repository or should it return the 404?

Previously it allowed to push to old remote url and it would still work as it was pushed to new repo location

[techknowlogick]

Interesting, it appears as though this is because git doesn't accept redirect headers, and we must've previously accepted pushes to renamed repos with a 200 instead of a 308.

This is also interesting as we allow pushes with or without .git trailing, so there should be similar logic.

[lunny]

I cannot reproduce this on main branch with http clone/pull/push when renaming the repository under the same user and also transfer to another org.

[chris-08154711]

I cannot reproduce this on main branch with http clone/pull/push when renaming the repository under the same user and also transfer to another org.

Steps to reproduce:

1. Clone a repo
2. Rename the repo (or move in another orga) in gitea
3. Check "git remote -v" on your clone - remote points to the original repo url/name
4. Try fetch/pull/push with the "invalid" remote url - not working!
5. The original url is still available in gitea UI but beeing 307 redirected to the renamed repo url

[chris-08154711]

@lunny comment above updated with steps and screenshots (sorry, was in a hurry yesterday and couldn't complete the post)

gitea version: 1.21.1
git client version: git version 2.41.0.windows.3

[newgreenshoot]

Just from attempting to quickly bisect this, the last tagged release where this worked was 1.21.0-rc2, and all subsequent versions can't pull/push from renamed repositories when using the old repository URL.

My team suspects that this PR introduced it: #27875

[lunny]

I cannot reproduce this on main branch with http clone/pull/push when renaming the repository under the same user and also transfer to another org.

Steps to reproduce:

1. Clone a repo

2. Rename the repo (or move in another orga) in gitea

3. Check "git remote -v" on your clone - remote points to the original repo url/name

4. Try fetch/pull/push with the "invalid" remote url - not working!

5. The original url is still available in gitea UI but beeing 307 redirected to the renamed repo url

It works for me on main branch.

[j123b567]

gitea: 1.21.5
git client: 2.44.0 and 2.43.0 on linux
gitea is behind reverse proxy using Apache 2.4.57

Running git clone with GIT_CURL_VERBOSE=1 and GIT_TRACE=1. This is HTTP communication from the trace.

POST /<redacted>/<redacted>.git/git-upload-pack HTTP/1.1
Host: <redacted>
Authorization: Basic <redacted>
User-Agent: git/2.44.0
Accept-Encoding: deflate, gzip
Content-Type: application/x-git-upload-pack-request
Accept: application/x-git-upload-pack-result
Accept-Language: cs-CZ, *;q=0.9
Git-Protocol: version=2
Content-Length: 175

HTTP/1.1 307 Temporary Redirect
Date: Tue, 05 Mar 2024 10:24:42 GMT
Server: Apache/2.4.57 (Debian)
Cache-Control: max-age=0, private, must-revalidate, no-transform
Location: /<redacted>/<redacted>/git-upload-pack
X-Frame-Options: SAMEORIGIN
Content-Length: 0
Set-Cookie: i_like_gitea=<redacted>; Path=/; HttpOnly; Secure; SameSite=Lax
Set-Cookie: _csrf=<redacted>; Path=/; Max-Age=86400; HttpOnly; Secure; SameSite=Lax

Same error
error: RPC failed; HTTP 307 curl 22 The requested URL returned error: 307

[le-patenteux]

I can confirm the issue. Using Gitea 1.21.7 with docker from the linuxserver.io image.
Since we are a small team, I simply had to reset the git origin on my local clone to the new name, but I had to look around for 30 minutes before I found the issue!
Good luck all