confusing indentation

[binford2k]

When typing out an indented block of code, the first line is indented with a [tab] character and the rest are indented with spaces. That makes for some really weird looking code. (And totally invalid code, if you're writing Python.)

https://try.gitea.io/nope/foobar/src/master/test.pp

[bkcsoft]

Where are you typing this?

[binford2k]

https://try.gitea.io/nope/foobar/src/master/test.pp

Click the edit pencil.

[bkcsoft]

In the web-editor then.

gitea/public/js/index.js

Lines 964 to 982 in fd85e25

	$.getJSON($editFilename.data('ec-url-prefix')+value, function(editorconfig) {
	if (editorconfig.indent_style === 'tab') {
	codeMirrorEditor.setOption("indentWithTabs", true);
	codeMirrorEditor.setOption('extraKeys', {});
	} else {
	codeMirrorEditor.setOption("indentWithTabs", false);
	// required because CodeMirror doesn't seems to use spaces correctly for {"indentWithTabs": false}:
	// - https://github.com/codemirror/CodeMirror/issues/988
	// - https://codemirror.net/doc/manual.html#keymaps
	codeMirrorEditor.setOption('extraKeys', {
	Tab: function(cm) {
	var spaces = Array(parseInt(cm.getOption("indentUnit")) + 1).join(" ");
	cm.replaceSelection(spaces);
	}
	});
	}
	codeMirrorEditor.setOption("indentUnit", editorconfig.indent_size || 4);
	codeMirrorEditor.setOption("tabSize", editorconfig.tab_width || 4);
	});

Looks like the editor config is only loaded when one edits the filename 🤔 And the order of setting it also seems off...

[bkcsoft]

On a side-note I noticed that the CodeMirror version we ship is very old https://github.com/codemirror/CodeMirror/releases/tag/5.17.0 and we should probably upgrade it to the newest version https://github.com/codemirror/CodeMirror/releases/tag/5.29.0

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[techknowlogick]

We could probably update to this version now: https://github.com/codemirror/CodeMirror/releases/tag/5.43.0

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[lafriks]

Can you recheck on try.gitea.io if problem has been solved with codemirror update