Attachments In Review Comment Break With Edit

[kdumontnu]

Description

To Reproduce

• Submit a review on design review with image attachments (I've only verified paste from clipboard)
  • images will automatically be inlined in markdown
• Edit the comment and delete one of the images
• All of the image/attachment links break

It seems as if all of the attachments are deleted when the review is edited.

Related to: #23290 and #24196

Gitea Version

1.18 and 1.20 (try.gitea)

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Paste some images (note: attachments aren't indicated)

Edit the review comment



All attachments are broken

Git Version

No response

Operating System

No response

How are you running Gitea?

https://try.gitea.io/kdumontnu/test/pulls/2

Database

None

[jtran]

Until proper editing of attachments on reviews is implemented, would adding ignore_attachments: true to the request fix the issue?

[wxiaoguang]

Good catch, the "attachment removal" code was already quite buggy before (this bug is not the first time appearing....)

I guess we need to rewrite it.

I am working on it.

[wxiaoguang]

I guess this PR could fix the bug: Fix issue attachment handling #24202