Missing links in PR after comments

[melmus]

• Gitea version (or commit ref): v1.15.0
• Git version: 2.30.2
• Operating system: Ubuntu 18.04.4 LTS
  Gitea running in docker
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
• Log gist:

Description

After i create PR and our team comments or review PR, message "user commented on this pull request" comes to email, but i do not see link to PR in message. On the screenshots you can see an example of this problem.

Screenshots

[prasadkatti]

Hi. I would like to work on fixing this issue. I have already done some triaging. The issue occurs because the template rendering fails with this error -

...vices/mailer/mail.go:301:composeIssueCommentMessages() [E] ExecuteTemplate [issue/default/body]: template: issue/default:65:10: executing "issue/default" at <.i18n.Tr>: can't evaluate field i18n in type *models.Comment

[zeripath]

change line 65 in templates/mail/issue/default.tmpl from:

gitea/templates/mail/issue/default.tmpl

Line 65 in 5a73153

{{.i18n.Tr "mail.issue.in_tree_path" .TreePath}}

to:

			{{$.i18n.Tr "mail.issue.in_tree_path" .TreePath}}

This bug is therefore a regression of #16200

and is backportable to 1.15

[prasadkatti]

@zeripath - Yes, thanks. I figured out that the i18n variable is defined in the outer scope and needs to be referenced using $.

[6543]

sorry missed that - thanks for the fix