Skip to content

Automatic Review Dismissal Fails To Properly Dismiss Review #16536

Open
@delvh

Description

@delvh
  • Gitea version (or commit ref): 1.14.4
  • Can you reproduce the bug at https://try.gitea.io: Don't know, for that I would need at least 2-3 people, but I presume you can

Description

The automatic review dismissal of a PR when new commits are added fails as apparently all it does is clear the approvals already gotten. Previous approvals will however still be displayed as approvals (if that is too confusing, look at the screenshot below to see what I mean)

Screenshots

image
Names of people not being me were cropped. As you can see, the PR is in the weird state where there are 0 approvals, although I approved a previous state, and it still looks as if I approved the PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions