Relative paths in Markdown <img> tags not working

[moqmar]

• Gitea version (or commit ref): ac84bb7
• Git version: N/A
• Operating system: Docker, using the provided Dockerfile
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes: https://try.gitea.io/momar/test
  • No
• Log gist: N/A

Description

<img src="test.jpg> in Markdown files now refers to the relative path as the browser would see it, while ![](test.jpg) refers to the relative path in the repository - before, both would work as a relative path. This was discovered in https://codeberg.org/Codeberg/Community/issues/478 and is explained there in more detail; also see the example repository (the uppermost two images were rendering before the commit referenced above and now aren't anymore).

Seems like this is a regression to #8830, which was solved by #10515. The problematic PR is #16098

Screenshots

[moqmar]

Aaah, I think I found the issue! node.Attr[idx].Val is not the same reference as attr.Val. See https://github.com/go-gitea/gitea/pull/16118/files#diff-5f0f1b16433e5c5930006aad7cc4f230bfafbe755452ffdf9c3c995623110fc4R417 respective line 423 in the old code.

[6543]

#16334