Wiki template error with golang 1.14

[kode9]

• Gitea version (or commit ref): 1.11.1
• Git version: 2.24.1
• Operating system: Docker Alpine 3.11
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

When building an image (not the official one) with golang:alpine (which, as of now, points to 1.14.0-alpine3.11), trying to view a wiki page result on a blank html page with this error from the template engine :

template: repo/wiki/view:48:14: executing "repo/wiki/view" at <(not $.DisableHTTP) (and (not $.DisableSSH) (or $.IsSigned $.ExposeAnonSSH))>: can't give argument to non-function not $.DisableHTTP

I did no try to rebuild the official image using golang 1.14, but it works fine if I build the same image with golang:1.13-alpine.

Also the issue was quite hard (for me) to track as there is no error in the logs even with all levels set to trace.

I think it might be related to #5697 and #4817

Screenshots

The wiki pages

After clicking on the page

P.S Note that the build layer of my image is nothing fancy :

  apk --no-cache add \
  build-base \
  git \
  nodejs \
  npm \
  && \
  git clone --single-branch --branch "v${GITEA_VERSION}" --depth 1 'https://github.com/go-gitea/gitea' && \
  cd gitea && \
  make clean build

[zeripath]

Problem is here:

gitea/templates/repo/wiki/view.tmpl

Line 48 in bea497f

{{if or ((not $.DisableHTTP) (and (not $.DisableSSH) (or $.IsSigned $.ExposeAnonSSH)))}}

The encoding parentheses on the or are unnecessary

[dkelsey]

The problem persists for me

I upgraded go and giteea at the same time to:

component	version
go	1.14.2
gitea	1.11.4

I clicked the wiki link (after restarting) and got the same error as was described by @kode9 in this ticket

template: repo/wiki/view:48:14: executing "repo/wiki/view" at <(not $.DisableHTTP) (and (not $.DisableSSH) (or $.IsSigned $.ExposeAnonSSH))>: can't give argument to non-function not $.DisableHTTP

I had a look at the merged fix from this issue: it described removing the opening and closing parentheses on line 48 of the wiki template. I did so on my local setup.
I re-compiled and ...

The problem persists.

template: repo/wiki/view:48:14: executing "repo/wiki/view" at <(not $.DisableHTTP) (and (not $.DisableSSH) (or $.IsSigned $.ExposeAnonSSH))>: can't give argument to non-function not $.DisableHTTP

Did the fix not get merged to 1.11.4?

[guillep2k]

@dkelsey No, this was not backported to 1.11. We're building 1.11 with go 1.13. See #10584.

[dkelsey]

@guillep2k Thanks I'll rebuild with go 1.13.

Edit: that worked. Thanks.

[stblassitude]

Any chance of this getting backported to 1.11? Some distributions (like FreeBSD) have switched to go 1.14 as a default, exposing this bug. Or what's the timeline for a 1.12 release, which presumably would be compatible with go 1.14?