Skip to content
This repository was archived by the owner on Dec 2, 2017. It is now read-only.

Translate Chinese to follow the English's changes #21

Merged
merged 4 commits into from
Dec 26, 2016
Merged

Translate Chinese to follow the English's changes #21

merged 4 commits into from
Dec 26, 2016

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 22, 2016

No description provided.

Copy link
Member

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single question, otherwise trusted LGTM from me, I can't read chinese :)


我们已经将所有的依赖项拷贝到本工程,我们提供了一些 [编译选项](https://github.com/go-gitea/gitea/blob/master/Makefile) 来让编译更简单。你可以按照你的需求来设置编译开关,可用编译选项如下:

* `bindata`: With this tag you can embed all assets required to run an instance of Gitea, this makes a deployment quite easy because you don't need to care about any additional file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I will send another commit.

@andreynering
Copy link
Contributor

LGTM

@tboerger
Copy link
Member

Missing the other commit

@tboerger
Copy link
Member

Trusted LGTM

@lunny
Copy link
Member Author

lunny commented Dec 24, 2016

I will send a PR to sync English version to this one after this LGTM

@appleboy
Copy link
Member

appleboy commented Dec 24, 2016

LGTM

@appleboy
Copy link
Member

Waiting merge zh-cn translations. I will start translate zh-cn to zh-tw. Thanks.

@lunny
Copy link
Member Author

lunny commented Dec 25, 2016

Drone?

go build -tags="bindata"
```

如果要使用bindata选项,你可能需要先执行go generate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple go generate will also call generate for vendor. It requires our packages as a parameter without the makefile. I suggest to document only the make process.

@lunny
Copy link
Member Author

lunny commented Dec 26, 2016

LGTM work?

@lunny lunny merged commit 1e47f8a into go-gitea:master Dec 26, 2016
@lunny lunny deleted the lunny/follow_en_updates branch December 26, 2016 00:53
@tboerger tboerger added this to the 1.0 milestone Dec 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants