Implement new method channels to avoid warnings #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the upgrade to Flutter 3.0 there were new method channels introduced. This commit implement a couple of them, to reduce the amount of warnings when running the project. Fixes go-flutter-desktop#667
bltavares
force-pushed
the
flutter-3-method-channels
branch
from
8558294 to
bf98504
Compare
pchampio
reviewed
Jul 22, 2022
| func (p *restorationPlugin) InitPlugin(messenger plugin.BinaryMessenger) error { | ||
| channel := plugin.NewMethodChannel(messenger, "flutter/restoration", plugin.StandardMethodCodec{}) | ||
| // Currently not supported. Used only to avoid warnings. | ||
| channel.HandleFunc("get", func(_ interface{}) (interface{}, error) { return nil, nil }) |
There was a problem hiding this comment.
I'm not sure about this, desktop CAN support restoration so it's better to either:
- Implement it
- Leave the warning
There was a problem hiding this comment.
There was a problem hiding this comment.
Humm, acutally, I don't know if this is a feature for desktop: https://api.flutter.dev/flutter/services/RestorationManager-class.html
Mobile operating systems use the concept of state restoration to provide the illusion that apps continue to run in the background forever
What do you think?
There was a problem hiding this comment.
i think it's not intended for desktop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the upgrade to Flutter 3.0 there were new method channels introduced.
This commit implement a couple of them, to reduce the amount of warnings when running the project.
Fixes #667