Fix segfault when running with Flutter 3.0 #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release of Flutter 3.0 caused apps to segfault when running with hover. The issue seems to be related to an updated ABI that required new headers to be compiled into `go-flutter` to make the interop compatible. This commit updates the `embedder.h` file to match the latest file from `flutter/flutter` allowing applications to run with the new version.
pchampio
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release of Flutter 3.0 caused apps to segfault when running with hover.
The issue seems to be related to an updated ABI that required new headers to be
compiled into
go-flutterto make the interop compatible.This commit updates the
embedder.hfile to match the latest file fromflutter/flutterallowing applications to run with the new version.