Skip to content

Fix VersionUnavailable warning #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

bltavares
Copy link
Contributor

When building an app on hover, we are getting the following error

GLFW: An uncaught error has occurred: VersionUnavailable: NSGL: Failed to create OpenGL context

This is happening when the Resource Window is created in background. The
Version hint requirements is being reverted to the initial values after we
create the main window, so the resource window does not have a version hint set.

This commit calls the global version hint code after we reset it, to ensure the
resource window have it set.

This fixes the warning, but it's not the actual root-cause to the Flutter 3.0 errors.
It is another warning that is misleading the investigation on that bug.

When building an app on hover, we are getting the following error

```
GLFW: An uncaught error has occurred: VersionUnavailable: NSGL: Failed to create OpenGL context
```

This is happening when the Resource Window is created in background. The
Version hint requirements is being reverted to the initial values after we
create the main window, so the resource window does not have a version hint set.

This commit calls the global version hint code after we reset it, to ensure the
resource window have it set.

This fixes the warning, but it's not the actual root-cause to the Flutter 3.0 errors.
It is another  warning that is misleading the investigation on that bug.
Copy link
Member

@pchampio pchampio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great work. I didn't know the GLFW framework worked that way.
LGTM

@pchampio pchampio merged commit f2fd800 into go-flutter-desktop:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants