Skip to content

pixelRatio wrong on built in MacOS display  #461

Closed
@etx

Description

@etx

When dragging the go-flutter window between an external display and the built in MBP Retina display the UI renders differently due to the pixelRatio that is calculated.

Hover doctor

hover doctor                                                                                                                                                                                       
hover: Hover version v0.42.0 running on darwin
hover: Sharing flutter version
Flutter 1.19.0-3.0.pre • channel master • https://github.com/flutter/flutter.git
Framework • revision 6135091de9 (20 hours ago) • 2020-06-01 17:17:03 -0700
Engine • revision e39301f23f
Tools • Dart 2.9.0 (build 2.9.0-11.0.dev 6489a0c68d)
hover: Flutter engine commit: https://github.com/flutter/engine/commit/e39301f23f324d1685678bcbb1682643e22b3a67
hover: ⚠ The go-flutter project tries to stay compatible with the beta channel of Flutter.
hover: ⚠     It's advised to use the beta channel: `flutter channel beta`
hover: Finding out the C compiler version
Apple clang version 11.0.3 (clang-1103.0.32.62)
Target: x86_64-apple-darwin19.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
hover: Sharing the content of go.mod
module aadyasecurity.com/thanos/thanos/go

go 1.13

require (
        github.com/bluecheeselab/golib/auth v0.0.0-20200525211053-6db9be31d271
        github.com/bluecheeselab/golib/thanos v0.0.0-20200526175402-e50267e6c360
        github.com/bluecheeselab/golib/tokens v0.0.0-20200525211053-6db9be31d271
        github.com/go-flutter-desktop/go-flutter v0.41.0
        github.com/go-gl/glfw/v3.3/glfw v0.0.0-20200420212212-258d9bec320e
        github.com/pkg/browser v0.0.0-20180916011732-0a3d74bf9ce4
        github.com/pkg/errors v0.9.1
        golang.org/x/crypto v0.0.0-20200429183012-4b2356b1ed79 // indirect
        golang.org/x/net v0.0.0-20200501053045-e0ff5e5a1de5 // indirect
        golang.org/x/sys v0.0.0-20200501145240-bc7a7d42d5c3 // indirect
)hover: Sharing the content of hover.yaml
application-name: ""
executable-name: ""
package-name: ""
license: ""
target: lib/main_desktop.dart
branch: ""
cache-path: ""
opengl: ""
engine-version: ""
hover: Sharing the content of go/cmd
go/cmd/authPlugin.go    go/cmd/jwtPlugin.go     go/cmd/main.go  go/cmd/options.go       go/cmd/vaultStream.go   go/cmd/windowPlugin.go

Error output

External Display:

go-flutter: calculated pixelRatio limited to a minimum of 1.0. metrics: {"dpi":109.08364544319599,"monitorWidthMm":801,"monitorWidthSc":3440,"mscpi":109.08364544319599,"pixelRatio":0.681772784019975,"ppsc":1,"windowWidthPx":960,"windowWidthSc":960}

Built in Macbook pro retina display

go-flutter: calculated pixelRatio limited to a minimum of 1.0. metrics: {"dpi":258.6181818181818,"monitorWidthMm":330,"monitorWidthSc":1680,"mscpi":129.3090909090909,"pixelRatio":1.6163636363636364,"ppsc":2,"windowWidthPx":1920,"windowWidthSc":960}

Metadata

Metadata

Assignees

No one assigned

    Labels

    GLFWMacOSSpecifically concerns MacOSenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions