Skip to content

Make borderColor optional #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2018
Merged

Make borderColor optional #7

merged 1 commit into from
Jan 11, 2018

Conversation

dy
Copy link
Member

@dy dy commented Jan 9, 2018

That forces clearing the whole canvas every draw call, which is unnecessary.
Since we don't use borderColor in plotly.js, it seems reasonable making it off-able.

@dy dy mentioned this pull request Jan 9, 2018
Merged
@etpinard
Copy link
Member

💃 can you merge, release and bump the gl-plot2d version in the plotly.js package.json.

Thanks!

@dy dy merged commit 5f68e83 into master Jan 11, 2018
@dy dy deleted the optional-bordercolor branch January 11, 2018 14:16
@dy
Copy link
Member Author

dy commented Jan 11, 2018

@etpinard done plotly/plotly.js@cd38db2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dy @etpinard