-
-
Notifications
You must be signed in to change notification settings - Fork 619
Fix typos #2649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix typos #2649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
filetreelist/src/filetreeitems.rs
Outdated
@@ -611,10 +611,10 @@ mod tests { | |||
|
|||
tree.collapse(1, false); | |||
|
|||
let visibles = get_visible(&tree); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one was actually right, or at least intentional -- get_visible
returns for each tree item whether it's visible or not, so a list of visible
s, so a visibles
. If anything, I would rename both the variable and the helper function to visibilities
and get_visibilities
, respectively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ada4a FYI. I tried update the changes, but obtain lots of errors during make check
. Hence, I reverted the changes to keep the fixes small.
This Pull Request fixes/closes #{issue_num}.
It changes the following:
typos --hidden --format brief
I followed the checklist:
make check
without errors