Skip to content

Pinentry for signing a commit does not recognize every key press when executed via gitui. #2395

Open
@dataCobra

Description

@dataCobra

Describe the bug

I'm using a Nitrokey with a PGP key which I also use for signing commits in multiple repositories.

When trying to commit with gitui the ncurses pinentry comes up and I try to input my password. While trying I notice that not every key press is registered and I sometimes need to press a key multiple times to get the press through to ncurses pinentry.

Also I noticed that gitui is not recovering safe from a wrong pinentry and the terminal needs a reset.

To Reproduce
Steps to reproduce the behavior:

  1. Use ncurses pinentry. (Add pinentry-program /usr/bin/pinentry-curses to your gpg-agent.conf)
  2. Open gitui and try to commit something where the pinentry comes up.
  3. pinentry is not recognizing every key press as stated in the description.

Expected behavior
Every key press gets through to the pinentry software. Like it is when using pinentry without gitui.

Context (please complete the following information):

  • OS/Distro + Version: Void Linux - Kernel 6.11.3 - UpToDate
  • GitUI Version: 0.26.3
  • Rust version: 1.82.0

Additional context
I've installed gitui via cargo install.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions