-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[ws-daemon] Support rootfs quota #7260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #7260 +/- ##
==========================================
- Coverage 19.04% 16.29% -2.76%
==========================================
Files 2 26 +24
Lines 168 3320 +3152
==========================================
+ Hits 32 541 +509
- Misses 134 2717 +2583
- Partials 2 62 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
f577f1f
to
911c5b2
Compare
3bce9e8
to
08feef9
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/werft run with-vm 👍 started the job as gitpod-build-cw-rootfs-quota.5 |
/werft run with-vm=true 👍 started the job as gitpod-build-cw-rootfs-quota.6 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hey @csweichel , do we still need this PR? I've temporarily removed it from the Workspace Team project to begin shrinking the Scheduled column. If yes, I'd like to find a home (in the form of an epic). Does it fit nicely into an existing one? I skimmed the list, and nothing jumped out at me. |
Yep, we still want this PR - we just need to find time to see it through. |
@csweichel @kylos101 I think we have already implemented this feature, right? |
Description
This PR adds XFS-based quota support to the rootfs of containers.
Ephemeral storage in Kubernetes does not encompass this.
How to test
containerRootfsQuota
to a value other than zero in the configdf -h
output in the workspaceRelease Notes