Skip to content

[ws-daemon] Support rootfs quota #7260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[ws-daemon] Support rootfs quota #7260

wants to merge 2 commits into from

Conversation

csweichel
Copy link
Contributor

Description

This PR adds XFS-based quota support to the rootfs of containers.
Ephemeral storage in Kubernetes does not encompass this.

How to test

  • Run on a cluster with XFS on the container root FS
  • Set the containerRootfsQuota to a value other than zero in the config
  • Start a workspace and look for errors from ws-daemon
  • Check the df -h output in the workspace

Release Notes

NONE

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from csweichel after the PR has been reviewed.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat added team: workspace Issue belongs to the Workspace team size/M labels Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #7260 (08feef9) into main (38c3d8e) will decrease coverage by 2.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7260      +/-   ##
==========================================
- Coverage   19.04%   16.29%   -2.76%     
==========================================
  Files           2       26      +24     
  Lines         168     3320    +3152     
==========================================
+ Hits           32      541     +509     
- Misses        134     2717    +2583     
- Partials        2       62      +60     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-daemon-app 21.96% <ø> (?)
components-ws-daemon-lib 21.96% <ø> (?)
installer-raw-app 5.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 29.71% <0.00%> (ø)
installer/pkg/common/ca.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/quota/xfs.go 45.05% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 33.33% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
installer/pkg/common/render.go 0.00% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stale
Copy link

stale bot commented Dec 31, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 31, 2021
@csweichel csweichel removed the meta: stale This issue/PR is stale and will be closed soon label Jan 3, 2022
@csweichel
Copy link
Contributor Author

csweichel commented Jan 5, 2022

/werft run with-vm

👍 started the job as gitpod-build-cw-rootfs-quota.5

@csweichel
Copy link
Contributor Author

csweichel commented Jan 5, 2022

/werft run with-vm=true

👍 started the job as gitpod-build-cw-rootfs-quota.6

@stale
Copy link

stale bot commented Jan 15, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jan 15, 2022
@aledbf aledbf added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Jan 15, 2022
@kylos101
Copy link
Contributor

kylos101 commented Feb 2, 2022

Hey @csweichel , do we still need this PR? I've temporarily removed it from the Workspace Team project to begin shrinking the Scheduled column.

If yes, I'd like to find a home (in the form of an epic). Does it fit nicely into an existing one? I skimmed the list, and nothing jumped out at me.

Also, checkout this epic home:
dome house

@kylos101 kylos101 removed the team: workspace Issue belongs to the Workspace team label Feb 2, 2022
@csweichel
Copy link
Contributor Author

Yep, we still want this PR - we just need to find time to see it through.
I don't think it warrants an epic on its own, but would fit in a general "improved resource isolation" story.

@utam0k
Copy link
Contributor

utam0k commented Aug 28, 2022

@csweichel @kylos101 I think we have already implemented this feature, right?

@reviewpad reviewpad bot mentioned this pull request Apr 4, 2023
9 tasks
@kylos101 kylos101 closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants