Skip to content

test: add notification color coverage #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/typesGithub.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,11 @@ export type IssueStateType =
| 'completed'
| 'reopened'
| 'not_planned';

export type PullRequestStateType = 'closed' | 'open' | 'merged' | 'draft';

export type StateType = IssueStateType | PullRequestStateType;

export type ViewerSubscription = 'IGNORED' | 'SUBSCRIBED' | 'UNSUBSCRIBED';

export interface Notification {
Expand Down
21 changes: 21 additions & 0 deletions src/utils/__snapshots__/github-api.test.ts.snap
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`./utils/github-api.ts should format the notification color 1`] = `"text-red-500"`;

exports[`./utils/github-api.ts should format the notification color 2`] = `"text-purple-500"`;

exports[`./utils/github-api.ts should format the notification color 3`] = `"text-gray-600"`;

exports[`./utils/github-api.ts should format the notification color 4`] = `"text-purple-500"`;

exports[`./utils/github-api.ts should format the notification color 5`] = `"text-gray-300"`;

exports[`./utils/github-api.ts should format the notification color 6`] = `"text-green-500"`;

exports[`./utils/github-api.ts should format the notification color 7`] = `"text-green-500"`;

exports[`./utils/github-api.ts should format the notification color 8`] = `
{
"description": "The reason for this notification is not supported by the app.",
"type": "Unknown",
}
`;

exports[`./utils/github-api.ts should format the notification reason 1`] = `
{
"description": "You were assigned to the issue.",
Expand Down
17 changes: 16 additions & 1 deletion src/utils/github-api.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import { formatReason, getNotificationTypeIcon } from './github-api';
import {
formatReason,
getNotificationTypeIcon,
getNotificationTypeIconColor,
} from './github-api';
import { Reason, SubjectType } from '../typesGithub';

describe('./utils/github-api.ts', () => {
Expand Down Expand Up @@ -62,4 +66,15 @@ describe('./utils/github-api.ts', () => {
'QuestionIcon',
);
});

it('should format the notification color', () => {
expect(getNotificationTypeIconColor('closed')).toMatchSnapshot();
expect(getNotificationTypeIconColor('completed')).toMatchSnapshot();
expect(getNotificationTypeIconColor('draft')).toMatchSnapshot();
expect(getNotificationTypeIconColor('merged')).toMatchSnapshot();
expect(getNotificationTypeIconColor('not_planned')).toMatchSnapshot();
expect(getNotificationTypeIconColor('open')).toMatchSnapshot();
expect(getNotificationTypeIconColor('reopened')).toMatchSnapshot();
expect(formatReason('something_else_unknown' as Reason)).toMatchSnapshot();
});
});
16 changes: 8 additions & 8 deletions src/utils/github-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,18 +119,18 @@ export function getNotificationTypeIconColor(state: StateType): string {
switch (state) {
case 'closed':
return 'text-red-500';
case 'open':
return 'text-green-500';
case 'merged':
return 'text-purple-500';
case 'reopened':
return 'text-green-500';
case 'not_planned':
return 'text-gray-300';
case 'completed':
return 'text-purple-500';
case 'draft':
return 'text-gray-600';
case 'merged':
return 'text-purple-500';
case 'not_planned':
return 'text-gray-300';
case 'open':
return 'text-green-500';
case 'reopened':
return 'text-green-500';
default:
return 'text-gray-300';
}
Expand Down