Skip to content

feat: linked issue indicator #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2024
Merged

feat: linked issue indicator #1160

merged 5 commits into from
Jun 3, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented May 31, 2024

Parse PR body to extract linked issues/prs and display a visual indicator with appropriate mouse-over text

Screenshot 2024-05-30 at 10 27 55 PM

@setchy setchy added the enhancement New feature or enhancement to existing functionality label May 31, 2024
@setchy setchy added this to the Release 5.7.0 milestone May 31, 2024
@bmulholland
Copy link
Collaborator

Is this something you'd use? I wouldn't, so would just be visual noise for me

@setchy
Copy link
Member Author

setchy commented May 31, 2024

Is this something you'd use? I wouldn't, so would just be visual noise for me

I'm on the fence too... It's in the GitHub Web UI, but not their mobile apps (as best as I can tell)...

It could be put behind a display setting if noise was a concern

@bmulholland
Copy link
Collaborator

Copying the Github UI is a good argument for doing it, noise or not :)

@setchy
Copy link
Member Author

setchy commented Jun 2, 2024

Updated to use "pill" format as to be introduced via #1169

Screenshot 2024-06-02 at 3 29 54 PM

Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the pill, this looks pretty cool, thanks @setchy!

@afonsojramos afonsojramos merged commit 6dc1c69 into main Jun 3, 2024
7 checks passed
@afonsojramos afonsojramos deleted the feature/pr-issues-visual branch June 3, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants