Skip to content

refactor: login methods and options #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2024
Merged

refactor: login methods and options #1158

merged 2 commits into from
May 31, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented May 30, 2024 •
edited
Loading

Further split from #1139

  • rename login methods
  • move common logic into a utils/auth folder

@setchy setchy added the refactor Refactoring of existing feature label May 30, 2024
@setchy setchy added this to the Release 5.7.0 milestone May 30, 2024
@setchy setchy marked this pull request as draft May 30, 2024 10:14
@setchy setchy changed the title refactor: rename login methods and options refactor: login methods and options May 30, 2024
@setchy setchy marked this pull request as ready for review May 30, 2024 11:39
@setchy setchy merged commit 41af015 into main May 31, 2024
7 checks passed
@setchy setchy deleted the refactor/login-with branch May 31, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland approved these changes

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @bmulholland