Stop re-ordering notifications when I mark one as read

[alanhogan]

I find it disorienting that notifications rearrange when I am marking some of them as 'read'. Since they group by repo, if I mark one the newest notification from repo B as read, this may cause repo A to jump ahead of repo B in the list.

This can cause mis-clicks and certainly makes me feel like the rug has been yanked out from underneath me.

I would suggest only re-ordering when new results come from the server and/or when the window is closed or blurred and subsequently opened/focused.

[afonsojramos]

@setchy I'm not sure that #1092 solves the issue per se. It does present an alternative fix, but I think that we still could pin the order per fetch, ie, not sorting per render. But maybe this would involve a major refactoring.

[setchy]

Yeah, it's like a small bandaid 🩹 😄

Reopened to keep us on our toes

[bquorning]

I am not sure why this issue was closed again. I am using v5.11.0 and the notifications are definitely still jumping around.