added support for managing the packagecloud repo's #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added packagecloud module as a dependency
tomkrouper
reviewed
Feb 10, 2017
| ], | ||
| "dependencies": [ | ||
| { "name": "puppetlabs/stdlib", "version_requirement": ">= 3.2.0 <5.0.0" }, | ||
| { "name": "computology/packagecloud", "version_requirement": ">= 0.2.0" } |
There was a problem hiding this comment.
Should this be computology/computology-packagecloud?
There was a problem hiding this comment.
i think it needs to be the reference to the puppet forge: https://forge.puppet.com/computology/packagecloud (which links back to the github repo you mentioned)
|
@mcrauwel, can you add the assumption to the README.md with the new module required. Also, can you verify that you've tested. (We need to add automated testing on this at some point.) Once that is done, I think we are 👍 |
added basic usage example for testing
|
@tomkrouper I've added the new feature to the README.md with the note for the dependency. I've also added a basic example file to verify the installation! |
tomkrouper
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added packagecloud module as a dependency