Skip to content

Alter the description of get-me to reduce redundant repeat calls #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

SamMorrowDrums
Copy link
Collaborator

A lot of times the get-me tool is called multiple times in a row, which is redundant. This attempts to address this, by explaining to the model it will not be updated normally.

@Copilot Copilot AI review requested due to automatic review settings May 19, 2025 10:59
@SamMorrowDrums SamMorrowDrums requested a review from a team as a code owner May 19, 2025 10:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the description of the get_me tool to note that its output is static unless the user updates their profile, discouraging redundant repeated calls.

  • Enhanced tool description in GetMe to mention caching behavior
  • Clarified that the response won’t change unless the profile is updated

@@ -15,7 +15,7 @@ import (
// GetMe creates a tool to get details of the authenticated user.
func GetMe(getClient GetClientFn, t translations.TranslationHelperFunc) (tool mcp.Tool, handler server.ToolHandlerFunc) {
return mcp.NewTool("get_me",
mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION", "Get details of the authenticated GitHub user. Use this when a request include \"me\", \"my\"...")),
mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION", "Get details of the authenticated GitHub user. Use this when a request include \"me\", \"my\"... the output will not change unless the user changes their profile, so only call this once.")),
Copy link
Preview

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Style: replace the ellipsis and run-on sentence with two clear sentences. For example: "... "my". The output remains unchanged unless the user updates their profile, so a single call is sufficient."

Suggested change
mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION", "Get details of the authenticated GitHub user. Use this when a request include \"me\", \"my\"... the output will not change unless the user changes their profile, so only call this once.")),
mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION", "Get details of the authenticated GitHub user. Use this when a request includes \"me\" or \"my\". The output will not change unless the user updates their profile. Therefore, only call this once.")),

Copilot uses AI. Check for mistakes.

williammartin
williammartin previously approved these changes May 19, 2025
Copy link
Collaborator

@williammartin williammartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with copilots suggestions (or at least, includes typo).

@SamMorrowDrums SamMorrowDrums merged commit 50043c3 into main May 19, 2025
16 checks passed
@SamMorrowDrums SamMorrowDrums deleted the get-me-description branch May 19, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants