Skip to content

feat: add golangci-lint-action to the lint workflow #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

radar07
Copy link
Contributor

@radar07 radar07 commented May 16, 2025

Closes: #406

@radar07 radar07 requested a review from a team as a code owner May 16, 2025 20:12
Copy link
Collaborator

@SamMorrowDrums SamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the simplicity just need to verify it doesn't this miss a couple of the checks from the existing implementation before merging.

Copy link
Collaborator

@williammartin williammartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radar07 thanks for doing this but it loses the go mod checks. Please ensure this still does go mod verify and asserts nothing has changed after go mod tidy.

It's ok to lose go fmt because golangci-lint does include that check.

@radar07
Copy link
Contributor Author

radar07 commented May 19, 2025

@williammartin I missed this totally. I removed the go fmt check and added golangci-lint step after the Run checks.

@radar07 radar07 force-pushed the add-golangci-lint-action branch from 14ed0ce to b620cc5 Compare May 19, 2025 14:11
@SamMorrowDrums SamMorrowDrums merged commit 2f8c287 into github:main May 19, 2025
9 checks passed
@radar07 radar07 deleted the add-golangci-lint-action branch May 19, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add golangci-lint-action to the lint workflow
3 participants