Skip to content

Remove circular link in warning #38441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

Remove circular link in warning #38441

merged 2 commits into from
May 20, 2025

Conversation

chohlasa
Copy link
Contributor

Why:

Closes: #38152

What's being changed (if available, include any code snippets, screenshots, or gifs):

This links to a page that does not contain additional information as was promised. This creates a circular link on the destination page. I was instructed by @Sharra-writes to open this PR to remove this link.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

Copy link

welcome bot commented May 20, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

github-actions bot commented May 20, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site.md fpt
ghec
fpt
ghec
from reusable
pages/configuring-a-custom-domain-for-your-github-pages-site/troubleshooting-custom-domains-and-github-pages.md fpt
ghec
fpt
ghec
from reusable
pages/configuring-a-custom-domain-for-your-github-pages-site/verifying-your-custom-domain-for-github-pages.md fpt
ghec
fpt
ghec
from reusable

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 20, 2025
@Sharra-writes
Copy link
Contributor

Awesome, looks great! I'll get it merged once checks are passing.

@Sharra-writes Sharra-writes added content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels May 20, 2025
@Sharra-writes Sharra-writes added this pull request to the merge queue May 20, 2025
Merged via the queue into github:main with commit a776b84 May 20, 2025
56 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard warning links to itself with no clarifying information
2 participants