Skip to content

Rename isPOD to isPod to silence deprecation warnings #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class DefinedSizeType extends Type {

class DefinedSizeClass extends Class {
DefinedSizeClass() {
this.isPOD() and
this.isPod() and
forall(Field f | f = this.getAField() | f.getType() instanceof DefinedSizeType)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ import codingstandards.cpp.Typehelpers
from Struct s
where
not isExcluded(s, ClassesPackage::nonPodTypeShouldBeDefinedAsClassQuery()) and
not s.isPOD()
not s.isPod()
select s, "Non-POD type defined as struct instead of class."
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import cpp
import codingstandards.cpp.autosar

class Object extends Class {
Object() { not this.(Struct).isPOD() }
Object() { not this.(Struct).isPod() }
}

predicate isPointerToObject(Expr e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ from HardwareOrProtocolInterfaceClass c
where
not isExcluded(c,
ClassesPackage::dataTypesUsedForInterfacingWithHardwareOrProtocolsMustBeTrivialAndStandardLayoutQuery()) and
not c.isPOD()
not c.isPod()
select c,
"Data type used for hardware interface or communication protocol is not standard layout and trivial."
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import cpp
import codingstandards.cpp.autosar

class NonPODType extends Class {
NonPODType() { not this.isPOD() }
NonPODType() { not this.isPod() }
}

from NonPODType p, Field f
Expand Down
2 changes: 1 addition & 1 deletion cpp/common/src/codingstandards/cpp/TrivialType.qll
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ predicate isTrivialType(Type t) {
/** A POD type as defined by [basic.types]/9. */
class PODType extends Type {
PODType() {
this.(Class).isPOD()
this.(Class).isPod()
or
isScalarType(this)
or
Expand Down