Implement PRE31-C
#275
Merged
Implement PRE31-C
#275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a heuristic query to find cases where arguments are provided to unsafe macros which have side-effects.
Refactor the query to create a separate class for representing unsafe macro invocations. This will enable the query to be improved by determining whether we actually observe multiple side-effects in practice (to handle cases like `type(e) = e;`.
A macro argument can be referred to multiple times in the body of a macro without it necessarily being evaluated multiple times - for example using an expression with sizeof, type etc. To handle these cases we ensure that we see multiple equivalent side-effects.
|
/test-matrix |
|
/test-matrix |
knewbury01
reviewed
Mar 29, 2023
* Add an implementation scope * Add qldocs * Update description.
knewbury01
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a heuristic query to find cases where arguments are provided to unsafe macros which have side-effects.
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
PRE31-CRelease change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.