Package SignalHandlers #258

mbaluda · 2023-03-16T22:15:09Z

Description

Implements package SignalHandlers:

SIG30-C
SIG31-C
SIG34-C
SIG35-C

Change request type

Release or process automation (GitHub workflows, internal scripts)
Internal documentation
External documentation
Query files (.ql, .qll, .qls or unit tests)
External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

No rules added
Queries have been added for the following rules:
- SIG30-C
- SIG31-C
- SIG34-C
- SIG35-C
Queries have been modified for the following rules:
- rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

Yes
No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Reviewer

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Extract library Signal.qll

…l-coding-standards into SignalHandlers

github-actions · 2023-03-21T01:09:47Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-21T01:12:32Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-21T01:13:16Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-21T01:14:20Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-21T01:14:23Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-21T01:14:36Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-21T01:14:58Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

github-actions · 2023-03-21T01:15:21Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-21T01:15:41Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-21T01:16:29Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-21T01:17:11Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-21T01:17:33Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-21T01:17:33Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-21T01:17:51Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-21T01:17:52Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-21T01:17:53Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-21T01:18:56Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

jsinglet · 2023-03-21T01:19:26Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-21T11:57:37Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-23T20:01:33Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-23T20:03:19Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
QUERY                : DoNotRelyOnIndeterminateValuesOfErrno
TEST_PASS            : True
RULE                 : ERR32-C
SUITE                : CERT-C
PACKAGE              : Contracts5
TEST_DIFFERENCE      : 

COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
QUERY                : CallOnlyAsyncSafeFunctionsWithinSignalHandlers
TEST_PASS            : True
RULE                 : SIG30-C
SUITE                : CERT-C
PACKAGE              : SignalHandlers
TEST_DIFFERENCE      : 

COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
QUERY                : DoNotAccessSharedObjectsInSignalHandlers
TEST_PASS            : True
RULE                 : SIG31-C
SUITE                : CERT-C
PACKAGE              : SignalHandlers
TEST_DIFFERENCE      : 

COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
QUERY                : DoNotCallSignalFromInterruptibleSignalHandlers
TEST_PASS            : True
RULE                 : SIG34-C
SUITE                : CERT-C
PACKAGE              : SignalHandlers
TEST_DIFFERENCE      : 

COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
QUERY                : DoNotReturnFromAComputationalExceptionHandler
TEST_PASS            : True
RULE                 : SIG35-C
SUITE                : CERT-C
PACKAGE              : SignalHandlers
TEST_DIFFERENCE      :

jsinglet · 2023-03-23T20:03:19Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


QUERY                : DoNotRelyOnIndeterminateValuesOfErrno
PACKAGE              : Contracts5
SUITE                : CERT-C
RULE                 : ERR32-C
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

QUERY                : CallOnlyAsyncSafeFunctionsWithinSignalHandlers
PACKAGE              : SignalHandlers
SUITE                : CERT-C
RULE                 : SIG30-C
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

QUERY                : DoNotAccessSharedObjectsInSignalHandlers
PACKAGE              : SignalHandlers
SUITE                : CERT-C
RULE                 : SIG31-C
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

QUERY                : DoNotCallSignalFromInterruptibleSignalHandlers
PACKAGE              : SignalHandlers
SUITE                : CERT-C
RULE                 : SIG34-C
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

QUERY                : DoNotReturnFromAComputationalExceptionHandler
PACKAGE              : SignalHandlers
SUITE                : CERT-C
RULE                 : SIG35-C
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

jsinglet · 2023-03-23T20:03:36Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-23T20:03:37Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-23T20:04:07Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

Package SignalHandlers

61c41f3

mbaluda self-assigned this Mar 16, 2023

mbaluda added 6 commits March 20, 2023 23:11

Implement SIG30-C

d10812f

Extract library Signal.qll

Fix CI issues

0be6b45

Fix CI issues

437d781

Merge branch 'main' into SignalHandlers

422088d

Rule SIG31-C

8b62761

Merge branch 'SignalHandlers' of https://github.com/mbaluda-org/codeq…

a3f10b2

…l-coding-standards into SignalHandlers

mbaluda added 2 commits March 21, 2023 02:14

Fix test SIG30-C

4b51d84

Fix expected file

2095248

Implement rule SIG34-C

e7dec51

github deleted a comment from jsinglet Mar 23, 2023

github deleted a comment from github-actions bot Mar 23, 2023

github deleted a comment from jsinglet Mar 23, 2023

github deleted a comment from github-actions bot Mar 23, 2023

github deleted a comment from jsinglet Mar 23, 2023

github deleted a comment from github-actions bot Mar 23, 2023

jsinglet approved these changes Mar 23, 2023

View reviewed changes

jsinglet enabled auto-merge March 23, 2023 20:41

jsinglet added this pull request to the merge queue Mar 23, 2023

Merged via the queue into github:main with commit 1c3ad1c Mar 23, 2023

mbaluda deleted the SignalHandlers branch April 3, 2023 10:42

Package SignalHandlers #258

Package SignalHandlers #258

Uh oh!

Conversation

mbaluda commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Change request type

Rules with added or modified queries

Release change checklist

Query development review checklist

Author

Reviewer

Uh oh!

github-actions bot commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

github-actions bot commented Mar 21, 2023

Uh oh!

github-actions bot commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 21, 2023

Uh oh!

github-actions bot commented Mar 21, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

Uh oh!

mbaluda commented Mar 16, 2023 •

edited

Loading