Fixes for #214 and 216 FP reports #253

knewbury01 · 2023-03-14T19:36:55Z

Description

fixes #214
fixes #216 - for this one, see some notes on the issue

Change request type

Release or process automation (GitHub workflows, internal scripts)
Internal documentation
External documentation
Query files (.ql, .qll, .qls or unit tests)
External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

No rules added
Queries have been added for the following rules:
- rule number here
Queries have been modified for the following rules:
- shared A12-10-1/RULE-5-3
- A5-1-1

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

Yes
No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Reviewer

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

exclude variable templates and fix case where same scope identifiers are considered

github-actions · 2023-03-14T19:37:22Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-14T19:38:33Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-14T19:38:33Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-14T19:38:47Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


PACKAGE              : Naming
COMPILE_PASS         : False
SUITE                : AUTOSAR
TEST_PASS            : False
QUERY                : IdentifierHiding
COMPILE_ERROR_OUTPUT : [2023-03-14 19:38:45] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:35:28: error: variable template partial specialization does not specialize any template argument; to define the primary template, remove the template argument list
                       [2023-03-14 19:38:45] [build-stderr] template <typename T> bool foo<T> = true; // COMPLIANT
                       [2023-03-14 19:38:45] [build-stderr]                            ^  ~~~
                       [2023-03-14 19:38:45] [build-stderr] 1 error generated.
                       [2023-03-14 19:38:46] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp:2:38: error: variable template partial specialization does not specialize any template argument; to define the primary template, remove the template argument list
                       [2023-03-14 19:38:46] [build-stderr] template <typename T> constexpr bool foo<T> = true; // COMPLIANT
                       [2023-03-14 19:38:46] [build-stderr]                                      ^  ~~~
                       [2023-03-14 19:38:46] [build-stderr] 1 error generated.
                       [2023-03-14 19:38:46] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql/tools/linux64/preload_tracer, clang++, -std=c++14, -fsyntax-only, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp])
                       
TEST_DIFFERENCE      : 
RULE                 : A2-10-1

jsinglet · 2023-03-14T19:39:10Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : False
RULE                 : A2-10-1
QUERY                : IdentifierHiding
PACKAGE              : Naming
COMPILE_ERROR_OUTPUT : [2023-03-14 19:39:09] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:35:28: error: partial specialization 'foo<T>' does not specialize any template arguments; to define the primary template, remove the template argument list
                       [2023-03-14 19:39:09] [build-stderr]  template <typename T> bool foo<T> = true; // COMPLIANT
                       [2023-03-14 19:39:09] [build-stderr]                             ^~~~~~
                       [2023-03-14 19:39:09] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:32:38: note: primary template here
                       [2023-03-14 19:39:09] [build-stderr]  template <typename T> constexpr bool foo = false; // COMPLIANT
                       [2023-03-14 19:39:09] [build-stderr]                                       ^~~
                       [2023-03-14 19:39:09] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:35:28: error: specialization of 'template<class T> constexpr const bool foo<T>' in different namespace [-fpermissive]
                       [2023-03-14 19:39:09] [build-stderr]  template <typename T> bool foo<T> = true; // COMPLIANT
                       [2023-03-14 19:39:09] [build-stderr]                             ^~~~~~
                       [2023-03-14 19:39:09] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:32:38: note:   from definition of 'template<class T> constexpr const bool foo<T>'
                       [2023-03-14 19:39:09] [build-stderr]  template <typename T> constexpr bool foo = false; // COMPLIANT
                       [2023-03-14 19:39:09] [build-stderr]                                       ^~~
                       [2023-03-14 19:39:09] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp:2:38: error: partial specialization 'foo<T>' does not specialize any template arguments; to define the primary template, remove the template argument list
                       [2023-03-14 19:39:09] [build-stderr]  template <typename T> constexpr bool foo<T> = true; // COMPLIANT
                       [2023-03-14 19:39:09] [build-stderr]                                       ^~~~~~
                       [2023-03-14 19:39:09] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp:1:38: note: primary template here
                       [2023-03-14 19:39:09] [build-stderr]  template <typename T> constexpr bool foo = false;   // COMPLIANT
                       [2023-03-14 19:39:09] [build-stderr]                                       ^~~
                       [2023-03-14 19:39:09] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql/tools/linux64/preload_tracer, g++, -std=c++14, -fsyntax-only, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp])
                       
SUITE                : AUTOSAR
TEST_DIFFERENCE      : 
COMPILE_PASS         : False

github-actions · 2023-03-14T19:41:32Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-14T19:42:42Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-14T19:42:43Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-14T19:42:47Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

jsinglet · 2023-03-14T19:43:00Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


PACKAGE              : Naming
COMPILE_ERROR_OUTPUT : [2023-03-14 19:42:59] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:35:28: error: partial specialization 'foo<T>' does not specialize any template arguments; to define the primary template, remove the template argument list
                       [2023-03-14 19:42:59] [build-stderr]  template <typename T> bool foo<T> = true; // COMPLIANT
                       [2023-03-14 19:42:59] [build-stderr]                             ^~~~~~
                       [2023-03-14 19:42:59] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:32:38: note: primary template here
                       [2023-03-14 19:42:59] [build-stderr]  template <typename T> constexpr bool foo = false; // COMPLIANT
                       [2023-03-14 19:42:59] [build-stderr]                                       ^~~
                       [2023-03-14 19:42:59] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:35:28: error: specialization of 'template<class T> constexpr const bool foo<T>' in different namespace [-fpermissive]
                       [2023-03-14 19:42:59] [build-stderr]  template <typename T> bool foo<T> = true; // COMPLIANT
                       [2023-03-14 19:42:59] [build-stderr]                             ^~~~~~
                       [2023-03-14 19:42:59] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:32:38: note:   from definition of 'template<class T> constexpr const bool foo<T>'
                       [2023-03-14 19:42:59] [build-stderr]  template <typename T> constexpr bool foo = false; // COMPLIANT
                       [2023-03-14 19:42:59] [build-stderr]                                       ^~~
                       [2023-03-14 19:42:59] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp:2:38: error: partial specialization 'foo<T>' does not specialize any template arguments; to define the primary template, remove the template argument list
                       [2023-03-14 19:42:59] [build-stderr]  template <typename T> constexpr bool foo<T> = true; // COMPLIANT
                       [2023-03-14 19:42:59] [build-stderr]                                       ^~~~~~
                       [2023-03-14 19:42:59] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp:1:38: note: primary template here
                       [2023-03-14 19:42:59] [build-stderr]  template <typename T> constexpr bool foo = false;   // COMPLIANT
                       [2023-03-14 19:42:59] [build-stderr]                                       ^~~
                       [2023-03-14 19:42:59] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql/tools/linux64/preload_tracer, g++, -std=c++14, -fsyntax-only, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp])
                       
TEST_DIFFERENCE      : 
SUITE                : AUTOSAR
TEST_PASS            : False
QUERY                : IdentifierHiding
RULE                 : A2-10-1
COMPILE_PASS         : False

jsinglet · 2023-03-14T19:43:01Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : False
SUITE                : AUTOSAR
RULE                 : A2-10-1
COMPILE_PASS         : False
PACKAGE              : Naming
COMPILE_ERROR_OUTPUT : [2023-03-14 19:42:59] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:35:28: error: variable template partial specialization does not specialize any template argument; to define the primary template, remove the template argument list
                       [2023-03-14 19:42:59] [build-stderr] template <typename T> bool foo<T> = true; // COMPLIANT
                       [2023-03-14 19:42:59] [build-stderr]                            ^  ~~~
                       [2023-03-14 19:42:59] [build-stderr] 1 error generated.
                       [2023-03-14 19:43:00] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp:2:38: error: variable template partial specialization does not specialize any template argument; to define the primary template, remove the template argument list
                       [2023-03-14 19:43:00] [build-stderr] template <typename T> constexpr bool foo<T> = true; // COMPLIANT
                       [2023-03-14 19:43:00] [build-stderr]                                      ^  ~~~
                       [2023-03-14 19:43:00] [build-stderr] 1 error generated.
                       [2023-03-14 19:43:00] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql/tools/linux64/preload_tracer, clang++, -std=c++14, -fsyntax-only, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp])
                       
TEST_DIFFERENCE      : 
QUERY                : IdentifierHiding

exclude file stream call args and heuristic wrappers

github-actions · 2023-03-16T21:42:44Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-16T21:44:24Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-16T21:45:44Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


RULE                 : A5-1-1
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : LiteralValueUsedOutsideTypeInit
TEST_DIFFERENCE      : 
PACKAGE              : Literals
COMPILE_ERROR_OUTPUT : 
SUITE                : AUTOSAR

RULE                 : A2-10-1
TEST_PASS            : False
COMPILE_PASS         : False
QUERY                : IdentifierHiding
TEST_DIFFERENCE      : 
PACKAGE              : Naming
COMPILE_ERROR_OUTPUT : [2023-03-16 21:45:42] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:35:28: error: variable template partial specialization does not specialize any template argument; to define the primary template, remove the template argument list
                       [2023-03-16 21:45:42] [build-stderr] template <typename T> bool foo<T> = true; // COMPLIANT
                       [2023-03-16 21:45:42] [build-stderr]                            ^  ~~~
                       [2023-03-16 21:45:42] [build-stderr] 1 error generated.
                       [2023-03-16 21:45:43] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp:2:38: error: variable template partial specialization does not specialize any template argument; to define the primary template, remove the template argument list
                       [2023-03-16 21:45:43] [build-stderr] template <typename T> constexpr bool foo<T> = true; // COMPLIANT
                       [2023-03-16 21:45:43] [build-stderr]                                      ^  ~~~
                       [2023-03-16 21:45:43] [build-stderr] 1 error generated.
                       [2023-03-16 21:45:43] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql/tools/linux64/preload_tracer, clang++, -std=c++14, -fsyntax-only, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp])
                       
SUITE                : AUTOSAR

jsinglet · 2023-03-16T21:46:23Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-16T21:47:38Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


QUERY                : LiteralValueUsedOutsideTypeInit
RULE                 : A5-1-1
TEST_DIFFERENCE      : 
SUITE                : AUTOSAR
PACKAGE              : Literals
COMPILE_PASS         : True
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 

QUERY                : IdentifierHiding
RULE                 : A2-10-1
TEST_DIFFERENCE      : 
SUITE                : AUTOSAR
PACKAGE              : Naming
COMPILE_PASS         : False
TEST_PASS            : False
COMPILE_ERROR_OUTPUT : [2023-03-16 21:47:37] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:35:28: error: partial specialization 'foo<T>' does not specialize any template arguments; to define the primary template, remove the template argument list
                       [2023-03-16 21:47:37] [build-stderr]  template <typename T> bool foo<T> = true; // COMPLIANT
                       [2023-03-16 21:47:37] [build-stderr]                             ^~~~~~
                       [2023-03-16 21:47:37] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:32:38: note: primary template here
                       [2023-03-16 21:47:37] [build-stderr]  template <typename T> constexpr bool foo = false; // COMPLIANT
                       [2023-03-16 21:47:37] [build-stderr]                                       ^~~
                       [2023-03-16 21:47:37] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:35:28: error: specialization of 'template<class T> constexpr const bool foo<T>' in different namespace [-fpermissive]
                       [2023-03-16 21:47:37] [build-stderr]  template <typename T> bool foo<T> = true; // COMPLIANT
                       [2023-03-16 21:47:37] [build-stderr]                             ^~~~~~
                       [2023-03-16 21:47:37] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp:32:38: note:   from definition of 'template<class T> constexpr const bool foo<T>'
                       [2023-03-16 21:47:37] [build-stderr]  template <typename T> constexpr bool foo = false; // COMPLIANT
                       [2023-03-16 21:47:37] [build-stderr]                                       ^~~
                       [2023-03-16 21:47:37] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp:2:38: error: partial specialization 'foo<T>' does not specialize any template arguments; to define the primary template, remove the template argument list
                       [2023-03-16 21:47:37] [build-stderr]  template <typename T> constexpr bool foo<T> = true; // COMPLIANT
                       [2023-03-16 21:47:37] [build-stderr]                                       ^~~~~~
                       [2023-03-16 21:47:37] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp:1:38: note: primary template here
                       [2023-03-16 21:47:37] [build-stderr]  template <typename T> constexpr bool foo = false;   // COMPLIANT
                       [2023-03-16 21:47:37] [build-stderr]                                       ^~~
                       [2023-03-16 21:47:37] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql/tools/linux64/preload_tracer, g++, -std=c++14, -fsyntax-only, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test.cpp, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/test/rules/identifierhidden/test1.cpp])

github-actions · 2023-03-17T14:36:22Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-17T14:37:42Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-17T14:37:42Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-17T14:39:14Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Literals
COMPILE_ERROR_OUTPUT : 
QUERY                : LiteralValueUsedOutsideTypeInit
SUITE                : AUTOSAR
TEST_DIFFERENCE      : 
RULE                 : A5-1-1

TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Naming
COMPILE_ERROR_OUTPUT : 
QUERY                : IdentifierHiding
SUITE                : AUTOSAR
TEST_DIFFERENCE      : 
RULE                 : A2-10-1

jsinglet · 2023-03-17T14:39:15Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


SUITE                : AUTOSAR
QUERY                : LiteralValueUsedOutsideTypeInit
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Literals
TEST_PASS            : True
RULE                 : A5-1-1

SUITE                : AUTOSAR
QUERY                : IdentifierHiding
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Naming
TEST_PASS            : True
RULE                 : A2-10-1

lcartey

A few suggested changes.

cpp/autosar/src/rules/A5-1-1/LiteralValueUsedOutsideTypeInit.ql

cpp/common/src/codingstandards/cpp/rules/identifierhidden/IdentifierHidden.qll

knewbury01 · 2023-03-30T15:54:16Z

/test-performance

…1/codeql-coding-standards into knewbury01/more-FP-fix

cpp/common/src/codingstandards/cpp/LoggingOperation.qll

reintroduce omission wrappers

knewbury01 added 2 commits March 14, 2023 15:28

Fix FP for issue 214

3d0b937

exclude variable templates and fix case where same scope identifiers are considered

Add missing change notes from fixes for issues 215 and 232

730b374

knewbury01 self-assigned this Mar 14, 2023

Fix change notes

3aaf853

Fix FP for issue 216

b09235f

exclude file stream call args and heuristic wrappers

knewbury01 enabled auto-merge March 16, 2023 21:44

knewbury01 requested a review from lcartey March 16, 2023 21:44

knewbury01 changed the title ~~Fixes for #214 FP reports~~ Fixes for #214 and 216 FP reports Mar 16, 2023

Fix testcase identifiershidden rule

507d34e

lcartey requested changes Mar 17, 2023

View reviewed changes

Improve fix for FP for issue 216

c6bcdf9

knewbury01 added 3 commits March 30, 2023 11:54

Merge branch 'main' into knewbury01/more-FP-fix

a8d6940

Format test A5-1-1

062e0e2

Merge branch 'knewbury01/more-FP-fix' of https://github.com/knewbury0…

5432a1d

…1/codeql-coding-standards into knewbury01/more-FP-fix

knewbury01 requested a review from lcartey March 30, 2023 16:31

lcartey requested changes Apr 19, 2023

View reviewed changes

cpp/common/src/codingstandards/cpp/LoggingOperation.qll Show resolved Hide resolved

Improve fix for FP for issue 216

e1190d8

reintroduce omission wrappers

knewbury01 requested a review from lcartey May 3, 2023 17:29

Merge branch 'main' into knewbury01/more-FP-fix

cd2154d

knewbury01 added this pull request to the merge queue May 18, 2023

lcartey approved these changes May 18, 2023

View reviewed changes

Merged via the queue into github:main with commit d4801f8 May 18, 2023

knewbury01 deleted the knewbury01/more-FP-fix branch May 18, 2023 16:24

Fixes for #214 and 216 FP reports #253

Fixes for #214 and 216 FP reports #253

Uh oh!

Conversation

knewbury01 commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Change request type

Rules with added or modified queries

Release change checklist

Query development review checklist

Author

Reviewer

Uh oh!

github-actions bot commented Mar 14, 2023

Uh oh!

jsinglet commented Mar 14, 2023

Uh oh!

jsinglet commented Mar 14, 2023

Uh oh!

jsinglet commented Mar 14, 2023

Uh oh!

jsinglet commented Mar 14, 2023

Uh oh!

github-actions bot commented Mar 14, 2023

Uh oh!

jsinglet commented Mar 14, 2023

Uh oh!

jsinglet commented Mar 14, 2023

Uh oh!

jsinglet commented Mar 14, 2023

Uh oh!

jsinglet commented Mar 14, 2023

Uh oh!

jsinglet commented Mar 14, 2023

Uh oh!

github-actions bot commented Mar 16, 2023

Uh oh!

jsinglet commented Mar 16, 2023

Uh oh!

jsinglet commented Mar 16, 2023

Uh oh!

jsinglet commented Mar 16, 2023

Uh oh!

jsinglet commented Mar 16, 2023

Uh oh!

github-actions bot commented Mar 17, 2023

Uh oh!

jsinglet commented Mar 17, 2023

Uh oh!

jsinglet commented Mar 17, 2023

Uh oh!

jsinglet commented Mar 17, 2023

Uh oh!

jsinglet commented Mar 17, 2023

Uh oh!

lcartey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

knewbury01 commented Mar 30, 2023

Uh oh!

Uh oh!

Uh oh!

knewbury01 commented Mar 14, 2023 •

edited

Loading