Skip to content

FIO38-C FIO47-C FIO42-C tests #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 8, 2023
Merged

FIO38-C FIO47-C FIO42-C tests #213

merged 13 commits into from
Mar 8, 2023

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Mar 1, 2023

Description

  • Fix compilation issue for test FIO38-C: the test built with Musl does not compile without a complete definition of FILE
  • Fix expected files for rule FIO47-C: the standard libraries have different definitions for intmax_t and size_t
  • Fix compilation issue for test FIO42-C: add header <sys/stat.h>

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql, .qll, .qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • rule number here
  • Queries have been modified for the following rules:
    • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

  • Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

@mbaluda mbaluda changed the title Update WrongTypeFormatArguments.expected FIO47-C test Mar 1, 2023
@mbaluda mbaluda changed the title FIO47-C test FIO38-C FIO47-C tests Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from github-actions bot Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@jsinglet
Copy link
Contributor

jsinglet commented Mar 2, 2023

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

@github github deleted a comment from github-actions bot Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from github-actions bot Mar 2, 2023
@github github deleted a comment from github-actions bot Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@github github deleted a comment from jsinglet Mar 2, 2023
@mbaluda mbaluda marked this pull request as ready for review March 6, 2023 18:36
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

@jsinglet
Copy link
Contributor

jsinglet commented Mar 6, 2023

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

jsinglet commented Mar 6, 2023

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

jsinglet commented Mar 6, 2023

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
PACKAGE              : IO2
COMPILE_PASS         : True
QUERY                : DoNotCopyAFileObject
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
RULE                 : FIO38-C

TEST_PASS            : True
PACKAGE              : IO4
COMPILE_PASS         : True
QUERY                : WrongNumberOfFormatArguments
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
RULE                 : FIO47-C

TEST_PASS            : True
PACKAGE              : IO4
COMPILE_PASS         : True
QUERY                : UseValidSpecifiers
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
RULE                 : FIO47-C

TEST_PASS            : True
PACKAGE              : IO4
COMPILE_PASS         : True
QUERY                : WrongTypeFormatArguments
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
RULE                 : FIO47-C


@jsinglet
Copy link
Contributor

jsinglet commented Mar 6, 2023

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
QUERY                : DoNotCopyAFileObject
PACKAGE              : IO2
RULE                 : FIO38-C
TEST_PASS            : True
SUITE                : CERT-C

COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
QUERY                : WrongNumberOfFormatArguments
PACKAGE              : IO4
RULE                 : FIO47-C
TEST_PASS            : True
SUITE                : CERT-C

COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
QUERY                : UseValidSpecifiers
PACKAGE              : IO4
RULE                 : FIO47-C
TEST_PASS            : True
SUITE                : CERT-C

COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
QUERY                : WrongTypeFormatArguments
PACKAGE              : IO4
RULE                 : FIO47-C
TEST_PASS            : True
SUITE                : CERT-C


@jsinglet
Copy link
Contributor

jsinglet commented Mar 6, 2023

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

@mbaluda mbaluda changed the title FIO38-C FIO47-C tests FIO38-C FIO47-C FIO42-C tests Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

@jsinglet
Copy link
Contributor

jsinglet commented Mar 6, 2023

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

jsinglet commented Mar 6, 2023

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

jsinglet commented Mar 6, 2023

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
TEST_PASS            : True
PACKAGE              : IO2
RULE                 : FIO38-C
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
QUERY                : DoNotCopyAFileObject

COMPILE_PASS         : True
TEST_PASS            : True
PACKAGE              : IO1
RULE                 : FIO42-C
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
QUERY                : CloseFilesWhenTheyAreNoLongerNeeded

COMPILE_PASS         : True
TEST_PASS            : True
PACKAGE              : IO4
RULE                 : FIO47-C
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
QUERY                : UseValidSpecifiers

COMPILE_PASS         : True
TEST_PASS            : True
PACKAGE              : IO4
RULE                 : FIO47-C
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
QUERY                : WrongNumberOfFormatArguments

COMPILE_PASS         : True
TEST_PASS            : True
PACKAGE              : IO4
RULE                 : FIO47-C
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
QUERY                : WrongTypeFormatArguments


@jsinglet
Copy link
Contributor

jsinglet commented Mar 6, 2023

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


RULE                 : FIO38-C
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
PACKAGE              : IO2
QUERY                : DoNotCopyAFileObject
SUITE                : CERT-C

RULE                 : FIO42-C
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
PACKAGE              : IO1
QUERY                : CloseFilesWhenTheyAreNoLongerNeeded
SUITE                : CERT-C

RULE                 : FIO47-C
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
PACKAGE              : IO4
QUERY                : UseValidSpecifiers
SUITE                : CERT-C

RULE                 : FIO47-C
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
PACKAGE              : IO4
QUERY                : WrongNumberOfFormatArguments
SUITE                : CERT-C

RULE                 : FIO47-C
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
PACKAGE              : IO4
QUERY                : WrongTypeFormatArguments
SUITE                : CERT-C


@jsinglet
Copy link
Contributor

jsinglet commented Mar 6, 2023

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

@jsinglet jsinglet self-requested a review March 7, 2023 16:08
@jsinglet jsinglet enabled auto-merge March 7, 2023 16:08
Copy link
Contributor

@jsinglet jsinglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsinglet jsinglet added this pull request to the merge queue Mar 7, 2023
@mbaluda mbaluda enabled auto-merge (squash) March 8, 2023 14:02
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

@jsinglet
Copy link
Contributor

jsinglet commented Mar 8, 2023

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

jsinglet commented Mar 8, 2023

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

jsinglet commented Mar 8, 2023

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : DoNotCopyAFileObject
TEST_DIFFERENCE      : 
PACKAGE              : IO2
RULE                 : FIO38-C
COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C

TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : CloseFilesWhenTheyAreNoLongerNeeded
TEST_DIFFERENCE      : 
PACKAGE              : IO1
RULE                 : FIO42-C
COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C

TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : UseValidSpecifiers
TEST_DIFFERENCE      : 
PACKAGE              : IO4
RULE                 : FIO47-C
COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C

TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : WrongNumberOfFormatArguments
TEST_DIFFERENCE      : 
PACKAGE              : IO4
RULE                 : FIO47-C
COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C

TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : WrongTypeFormatArguments
TEST_DIFFERENCE      : 
PACKAGE              : IO4
RULE                 : FIO47-C
COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C


@jsinglet
Copy link
Contributor

jsinglet commented Mar 8, 2023

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
TEST_PASS            : True
PACKAGE              : IO2
RULE                 : FIO38-C
QUERY                : DoNotCopyAFileObject
SUITE                : CERT-C
COMPILE_PASS         : True

COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
TEST_PASS            : True
PACKAGE              : IO1
RULE                 : FIO42-C
QUERY                : CloseFilesWhenTheyAreNoLongerNeeded
SUITE                : CERT-C
COMPILE_PASS         : True

COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
TEST_PASS            : True
PACKAGE              : IO4
RULE                 : FIO47-C
QUERY                : UseValidSpecifiers
SUITE                : CERT-C
COMPILE_PASS         : True

COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
TEST_PASS            : True
PACKAGE              : IO4
RULE                 : FIO47-C
QUERY                : WrongNumberOfFormatArguments
SUITE                : CERT-C
COMPILE_PASS         : True

COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
TEST_PASS            : True
PACKAGE              : IO4
RULE                 : FIO47-C
QUERY                : WrongTypeFormatArguments
SUITE                : CERT-C
COMPILE_PASS         : True


@jsinglet
Copy link
Contributor

jsinglet commented Mar 8, 2023

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

@mbaluda mbaluda merged commit 0e9bcdd into github:main Mar 8, 2023
@mbaluda mbaluda deleted the FIO47-tests branch March 8, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants