C++: Pull in the latest version of TaintedPath.ql
from CodeQL
#149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Note that this PR targets the
next
branch, which is used by the CodeQL CI to detect changes that breakgithub/codeql-coding-standards
. The changes from this PR should eventually be merged tomain
.)We plan to deprecate the
DefaultTaintTracking
library. As part of this all queries depending on the library will need to be rewritten. For coding standards this affectsDoNotPerformFileOperationsOnDevices.ql
from FIO32-C, which is a copy of CodeQL'sTaintedPath.ql
. This PR pulls in the initial rewrite we did on the CodeQL side here. The performance we measured is similar to that of the old version, we do see some result changes, which we accepted on the CodeQL side (the query is/was quite noisy in any case).Change request type
.ql
,.qll
,.qls
or unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.