BannedSyntax: assign scope to each query

lcartey · lcartey · commit 6eadab9abe47 · 2022-08-17T21:01:17.000+01:00
diff --git a/cpp/autosar/src/rules/A11-3-1/FriendDeclarationsUsed.ql b/cpp/autosar/src/rules/A11-3-1/FriendDeclarationsUsed.ql
@@ -8,6 +8,7 @@
  * @tags external/autosar/id/a11-3-1
  *       correctness
  *       security
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A18-1-1/CStyleArraysUsed.ql b/cpp/autosar/src/rules/A18-1-1/CStyleArraysUsed.ql
@@ -8,6 +8,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a18-1-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A2-11-1/VolatileKeywordUsed.ql b/cpp/autosar/src/rules/A2-11-1/VolatileKeywordUsed.ql
@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a2-11-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/design
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
diff --git a/cpp/autosar/src/rules/A5-16-1/TernaryConditionalOperatorUsedAsSubExpression.ql b/cpp/autosar/src/rules/A5-16-1/TernaryConditionalOperatorUsedAsSubExpression.ql
@@ -8,6 +8,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a5-16-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A5-2-1/DynamicCastShouldNotBeUsed.ql b/cpp/autosar/src/rules/A5-2-1/DynamicCastShouldNotBeUsed.ql
@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a5-2-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/advisory
diff --git a/cpp/autosar/src/rules/A5-2-2/TraditionalCStyleCastsUsed.ql b/cpp/autosar/src/rules/A5-2-2/TraditionalCStyleCastsUsed.ql
@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a5-2-2
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A5-2-4/ReinterpretCastUsed.ql b/cpp/autosar/src/rules/A5-2-4/ReinterpretCastUsed.ql
@@ -8,6 +8,7 @@
  * @tags external/autosar/id/a5-2-4
  *       correctness
  *       security
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A6-6-1/GotoStatementUsed.ql b/cpp/autosar/src/rules/A6-6-1/GotoStatementUsed.ql
@@ -8,6 +8,7 @@
  * @tags external/autosar/id/a6-6-1
  *       correctness
  *       security
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A7-1-4/RegisterKeywordUsed.ql b/cpp/autosar/src/rules/A7-1-4/RegisterKeywordUsed.ql
@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a7-1-4
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A7-1-6/TypedefSpecifierUsed.ql b/cpp/autosar/src/rules/A7-1-6/TypedefSpecifierUsed.ql
@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a7-1-6
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A7-4-1/AsmDeclarationUsed.ql b/cpp/autosar/src/rules/A7-4-1/AsmDeclarationUsed.ql
@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a7-4-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A8-4-1/FunctionsDefinedUsingTheEllipsisNotation.ql b/cpp/autosar/src/rules/A8-4-1/FunctionsDefinedUsingTheEllipsisNotation.ql
@@ -8,6 +8,7 @@
  * @tags external/autosar/id/a8-4-1
  *       correctness
  *       security
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A9-5-1/UnionsUsed.ql b/cpp/autosar/src/rules/A9-5-1/UnionsUsed.ql
@@ -8,6 +8,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a9-5-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/M5-18-1/CommaOperatorUsed.ql b/cpp/autosar/src/rules/M5-18-1/CommaOperatorUsed.ql
@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/m5-18-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/M7-3-4/UsingDirectivesUsed.ql b/cpp/autosar/src/rules/M7-3-4/UsingDirectivesUsed.ql
@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/m7-3-4
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/M7-3-6/UsingDeclarationsUsedInHeaderFiles.ql b/cpp/autosar/src/rules/M7-3-6/UsingDeclarationsUsedInHeaderFiles.ql
@@ -8,6 +8,7 @@
  * @problem.severity error
  * @tags external/autosar/id/m7-3-6
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/cert/src/rules/DCL50-CPP/DoNotDefineACStyleVariadicFunction.ql b/cpp/cert/src/rules/DCL50-CPP/DoNotDefineACStyleVariadicFunction.ql
@@ -8,6 +8,7 @@
  * @tags external/cert/id/dcl50-cpp
  *       correctness
  *       security
+ *       scope/single-translation-unit
  *       external/cert/obligation/rule
  */
 
diff --git a/rule_packages/cpp/BannedSyntax.json b/rule_packages/cpp/BannedSyntax.json
@@ -18,7 +18,8 @@
           "short_name": "FriendDeclarationsUsed",
           "tags": [
             "correctness",
-            "security"
+            "security",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -41,7 +42,8 @@
           "severity": "error",
           "short_name": "CStyleArraysUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -65,7 +67,8 @@
           "severity": "error",
           "short_name": "VolatileKeywordUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -88,7 +91,8 @@
           "severity": "error",
           "short_name": "TernaryConditionalOperatorUsedAsSubExpression",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -111,7 +115,8 @@
           "severity": "error",
           "short_name": "DynamicCastShouldNotBeUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -134,7 +139,8 @@
           "severity": "error",
           "short_name": "TraditionalCStyleCastsUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -158,7 +164,8 @@
           "short_name": "ReinterpretCastUsed",
           "tags": [
             "correctness",
-            "security"
+            "security",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -182,7 +189,8 @@
           "short_name": "GotoStatementUsed",
           "tags": [
             "correctness",
-            "security"
+            "security",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -205,7 +213,8 @@
           "severity": "error",
           "short_name": "RegisterKeywordUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -228,7 +237,8 @@
           "severity": "error",
           "short_name": "TypedefSpecifierUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -251,7 +261,8 @@
           "severity": "error",
           "short_name": "AsmDeclarationUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -275,7 +286,8 @@
           "short_name": "FunctionsDefinedUsingTheEllipsisNotation",
           "tags": [
             "correctness",
-            "security"
+            "security",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -298,7 +310,8 @@
           "severity": "error",
           "short_name": "UnionsUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -322,7 +335,8 @@
           "short_name": "CommaOperatorUsed",
           "shared_implementation_short_name": "CommaOperatorUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -345,7 +359,8 @@
           "severity": "error",
           "short_name": "UsingDirectivesUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -368,7 +383,8 @@
           "severity": "error",
           "short_name": "UsingDeclarationsUsedInHeaderFiles",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -390,11 +406,12 @@
           "short_name": "DoNotDefineACStyleVariadicFunction",
           "tags": [
             "correctness",
-            "security"
+            "security",
+            "scope/single-translation-unit"
           ]
         }
       ],
       "title": "Do not define a C-style variadic function"
     }
   }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,8 @@`
`18`	`18`	`"short_name": "FriendDeclarationsUsed",`
`19`	`19`	`"tags": [`
`20`	`20`	`"correctness",`
`21`		`- "security"`
	`21`	`+ "security",`
	`22`	`+ "scope/single-translation-unit"`
`22`	`23`	`]`
`23`	`24`	`}`
`24`	`25`	`],`
`@@ -41,7 +42,8 @@`
`41`	`42`	`"severity": "error",`
`42`	`43`	`"short_name": "CStyleArraysUsed",`
`43`	`44`	`"tags": [`
`44`		`- "correctness"`
	`45`	`+ "correctness",`
	`46`	`+ "scope/single-translation-unit"`
`45`	`47`	`]`
`46`	`48`	`}`
`47`	`49`	`],`
`@@ -65,7 +67,8 @@`
`65`	`67`	`"severity": "error",`
`66`	`68`	`"short_name": "VolatileKeywordUsed",`
`67`	`69`	`"tags": [`
`68`		`- "correctness"`
	`70`	`+ "correctness",`
	`71`	`+ "scope/single-translation-unit"`
`69`	`72`	`]`
`70`	`73`	`}`
`71`	`74`	`],`
`@@ -88,7 +91,8 @@`
`88`	`91`	`"severity": "error",`
`89`	`92`	`"short_name": "TernaryConditionalOperatorUsedAsSubExpression",`
`90`	`93`	`"tags": [`
`91`		`- "correctness"`
	`94`	`+ "correctness",`
	`95`	`+ "scope/single-translation-unit"`
`92`	`96`	`]`
`93`	`97`	`}`
`94`	`98`	`],`
`@@ -111,7 +115,8 @@`
`111`	`115`	`"severity": "error",`
`112`	`116`	`"short_name": "DynamicCastShouldNotBeUsed",`
`113`	`117`	`"tags": [`
`114`		`- "correctness"`
	`118`	`+ "correctness",`
	`119`	`+ "scope/single-translation-unit"`
`115`	`120`	`]`
`116`	`121`	`}`
`117`	`122`	`],`
`@@ -134,7 +139,8 @@`
`134`	`139`	`"severity": "error",`
`135`	`140`	`"short_name": "TraditionalCStyleCastsUsed",`
`136`	`141`	`"tags": [`
`137`		`- "correctness"`
	`142`	`+ "correctness",`
	`143`	`+ "scope/single-translation-unit"`
`138`	`144`	`]`
`139`	`145`	`}`
`140`	`146`	`],`
`@@ -158,7 +164,8 @@`
`158`	`164`	`"short_name": "ReinterpretCastUsed",`
`159`	`165`	`"tags": [`
`160`	`166`	`"correctness",`
`161`		`- "security"`
	`167`	`+ "security",`
	`168`	`+ "scope/single-translation-unit"`
`162`	`169`	`]`
`163`	`170`	`}`
`164`	`171`	`],`
`@@ -182,7 +189,8 @@`
`182`	`189`	`"short_name": "GotoStatementUsed",`
`183`	`190`	`"tags": [`
`184`	`191`	`"correctness",`
`185`		`- "security"`
	`192`	`+ "security",`
	`193`	`+ "scope/single-translation-unit"`
`186`	`194`	`]`
`187`	`195`	`}`
`188`	`196`	`],`
`@@ -205,7 +213,8 @@`
`205`	`213`	`"severity": "error",`
`206`	`214`	`"short_name": "RegisterKeywordUsed",`
`207`	`215`	`"tags": [`
`208`		`- "correctness"`
	`216`	`+ "correctness",`
	`217`	`+ "scope/single-translation-unit"`
`209`	`218`	`]`
`210`	`219`	`}`
`211`	`220`	`],`
`@@ -228,7 +237,8 @@`
`228`	`237`	`"severity": "error",`
`229`	`238`	`"short_name": "TypedefSpecifierUsed",`
`230`	`239`	`"tags": [`
`231`		`- "correctness"`
	`240`	`+ "correctness",`
	`241`	`+ "scope/single-translation-unit"`
`232`	`242`	`]`
`233`	`243`	`}`
`234`	`244`	`],`
`@@ -251,7 +261,8 @@`
`251`	`261`	`"severity": "error",`
`252`	`262`	`"short_name": "AsmDeclarationUsed",`
`253`	`263`	`"tags": [`
`254`		`- "correctness"`
	`264`	`+ "correctness",`
	`265`	`+ "scope/single-translation-unit"`
`255`	`266`	`]`
`256`	`267`	`}`
`257`	`268`	`],`
`@@ -275,7 +286,8 @@`
`275`	`286`	`"short_name": "FunctionsDefinedUsingTheEllipsisNotation",`
`276`	`287`	`"tags": [`
`277`	`288`	`"correctness",`
`278`		`- "security"`
	`289`	`+ "security",`
	`290`	`+ "scope/single-translation-unit"`
`279`	`291`	`]`
`280`	`292`	`}`
`281`	`293`	`],`
`@@ -298,7 +310,8 @@`
`298`	`310`	`"severity": "error",`
`299`	`311`	`"short_name": "UnionsUsed",`
`300`	`312`	`"tags": [`
`301`		`- "correctness"`
	`313`	`+ "correctness",`
	`314`	`+ "scope/single-translation-unit"`
`302`	`315`	`]`
`303`	`316`	`}`
`304`	`317`	`],`
`@@ -322,7 +335,8 @@`
`322`	`335`	`"short_name": "CommaOperatorUsed",`
`323`	`336`	`"shared_implementation_short_name": "CommaOperatorUsed",`
`324`	`337`	`"tags": [`
`325`		`- "correctness"`
	`338`	`+ "correctness",`
	`339`	`+ "scope/single-translation-unit"`
`326`	`340`	`]`
`327`	`341`	`}`
`328`	`342`	`],`
`@@ -345,7 +359,8 @@`
`345`	`359`	`"severity": "error",`
`346`	`360`	`"short_name": "UsingDirectivesUsed",`
`347`	`361`	`"tags": [`
`348`		`- "correctness"`
	`362`	`+ "correctness",`
	`363`	`+ "scope/single-translation-unit"`
`349`	`364`	`]`
`350`	`365`	`}`
`351`	`366`	`],`
`@@ -368,7 +383,8 @@`
`368`	`383`	`"severity": "error",`
`369`	`384`	`"short_name": "UsingDeclarationsUsedInHeaderFiles",`
`370`	`385`	`"tags": [`
`371`		`- "correctness"`
	`386`	`+ "correctness",`
	`387`	`+ "scope/single-translation-unit"`
`372`	`388`	`]`
`373`	`389`	`}`
`374`	`390`	`],`
`@@ -390,11 +406,12 @@`
`390`	`406`	`"short_name": "DoNotDefineACStyleVariadicFunction",`
`391`	`407`	`"tags": [`
`392`	`408`	`"correctness",`
`393`		`- "security"`
	`409`	`+ "security",`
	`410`	`+ "scope/single-translation-unit"`
`394`	`411`	`]`
`395`	`412`	`}`
`396`	`413`	`],`
`397`	`414`	`"title": "Do not define a C-style variadic function"`
`398`	`415`	`}`
`399`	`416`	`}`
`400`		`-}`
	`417`	`+}`