BannedLibraries: assign scope to each query

lcartey · lcartey · commit 1e5778273d88 · 2022-08-17T20:40:18.000+01:00
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
@@ -185,13 +185,11 @@
             "type": "pickString",
             "options": [
                 "Allocations",
-                "Banned",
                 "BannedFunctions",
+                "BannedLibraries",
                 "BannedSyntax",
                 "BannedTypes",
                 "Classes",
-                "Classes",
-                "Classes",
                 "Comments",
                 "Contracts1",
                 "Concurrency",
diff --git a/cpp/autosar/src/rules/A17-0-1/ReservedIdentifiersMacrosAndFunctionsAreDefinedRedefinedOrUndefined.ql b/cpp/autosar/src/rules/A17-0-1/ReservedIdentifiersMacrosAndFunctionsAreDefinedRedefinedOrUndefined.ql
@@ -14,6 +14,7 @@
  * @tags external/autosar/id/a17-0-1
  *       correctness
  *       maintainability
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A18-0-1/CLibraryFacilitiesNotAccessedThroughCPPLibraryHeaders.ql b/cpp/autosar/src/rules/A18-0-1/CLibraryFacilitiesNotAccessedThroughCPPLibraryHeaders.ql
@@ -9,6 +9,7 @@
  * @tags external/autosar/id/a18-0-1
  *       correctness
  *       readability
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A18-0-3/LocaleFunctionsUsed.ql b/cpp/autosar/src/rules/A18-0-3/LocaleFunctionsUsed.ql
@@ -14,6 +14,7 @@
  * @problem.severity warning
  * @tags external/autosar/id/a18-0-3
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A18-0-3/LocaleMacrosUsed.ql b/cpp/autosar/src/rules/A18-0-3/LocaleMacrosUsed.ql
@@ -9,6 +9,7 @@
  * @problem.severity warning
  * @tags external/autosar/id/a18-0-3
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/A18-0-3/LocaleTypeLConvUsed.ql b/cpp/autosar/src/rules/A18-0-3/LocaleTypeLConvUsed.ql
@@ -8,6 +8,7 @@
  * @problem.severity warning
  * @tags external/autosar/id/a18-0-3
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/M18-7-1/CsignalFunctionsUsed.ql b/cpp/autosar/src/rules/M18-7-1/CsignalFunctionsUsed.ql
@@ -8,6 +8,7 @@
  * @tags external/autosar/id/m18-7-1
  *       maintainability
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/M18-7-1/CsignalTypesUsed.ql b/cpp/autosar/src/rules/M18-7-1/CsignalTypesUsed.ql
@@ -8,6 +8,7 @@
  * @tags external/autosar/id/m18-7-1
  *       maintainability
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/M19-3-1/ErrnoUsed.ql b/cpp/autosar/src/rules/M19-3-1/ErrnoUsed.ql
@@ -10,6 +10,7 @@
  * @tags external/autosar/id/m19-3-1
  *       correctness
  *       maintainability
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/M27-0-1/CstdioFunctionsUsed.ql b/cpp/autosar/src/rules/M27-0-1/CstdioFunctionsUsed.ql
@@ -9,6 +9,7 @@
  * @tags external/autosar/id/m27-0-1
  *       maintainability
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/M27-0-1/CstdioMacrosUsed.ql b/cpp/autosar/src/rules/M27-0-1/CstdioMacrosUsed.ql
@@ -9,6 +9,7 @@
  * @tags external/autosar/id/m27-0-1
  *       maintainability
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/M27-0-1/CstdioTypesUsed.ql b/cpp/autosar/src/rules/M27-0-1/CstdioTypesUsed.ql
@@ -9,6 +9,7 @@
  * @tags external/autosar/id/m27-0-1
  *       maintainability
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required
diff --git a/cpp/autosar/src/rules/M7-4-1/UsageOfAssemblerNotDocumented.ql b/cpp/autosar/src/rules/M7-4-1/UsageOfAssemblerNotDocumented.ql
@@ -8,6 +8,7 @@
  * @tags external/autosar/id/m7-4-1
  *       readability
  *       maintainability
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/audit
  *       external/autosar/enforcement/non-automated
diff --git a/rule_packages/cpp/BannedLibraries.json b/rule_packages/cpp/BannedLibraries.json
@@ -18,7 +18,8 @@
           "short_name": "ReservedIdentifiersMacrosAndFunctionsAreDefinedRedefinedOrUndefined",
           "tags": [
             "correctness",
-            "maintainability"
+            "maintainability",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -42,7 +43,8 @@
           "short_name": "CLibraryFacilitiesNotAccessedThroughCPPLibraryHeaders",
           "tags": [
             "correctness",
-            "readability"
+            "readability",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -65,7 +67,8 @@
           "severity": "warning",
           "short_name": "LocaleFunctionsUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         },
         {
@@ -76,7 +79,8 @@
           "severity": "warning",
           "short_name": "LocaleMacrosUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         },
         {
@@ -87,7 +91,8 @@
           "severity": "warning",
           "short_name": "LocaleTypeLConvUsed",
           "tags": [
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -111,7 +116,8 @@
           "short_name": "CsignalFunctionsUsed",
           "tags": [
             "maintainability",
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         },
         {
@@ -123,7 +129,8 @@
           "short_name": "CsignalTypesUsed",
           "tags": [
             "maintainability",
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -147,7 +154,8 @@
           "short_name": "ErrnoUsed",
           "tags": [
             "correctness",
-            "maintainability"
+            "maintainability",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -171,7 +179,8 @@
           "short_name": "CstdioFunctionsUsed",
           "tags": [
             "maintainability",
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         },
         {
@@ -183,7 +192,8 @@
           "short_name": "CstdioMacrosUsed",
           "tags": [
             "maintainability",
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         },
         {
@@ -195,7 +205,8 @@
           "short_name": "CstdioTypesUsed",
           "tags": [
             "maintainability",
-            "correctness"
+            "correctness",
+            "scope/single-translation-unit"
           ]
         }
       ],
@@ -220,7 +231,8 @@
           "short_name": "UsageOfAssemblerNotDocumented",
           "tags": [
             "readability",
-            "maintainability"
+            "maintainability",
+            "scope/single-translation-unit"
           ]
         }
       ],

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,8 @@`
`18`	`18`	`"short_name": "ReservedIdentifiersMacrosAndFunctionsAreDefinedRedefinedOrUndefined",`
`19`	`19`	`"tags": [`
`20`	`20`	`"correctness",`
`21`		`- "maintainability"`
	`21`	`+ "maintainability",`
	`22`	`+ "scope/single-translation-unit"`
`22`	`23`	`]`
`23`	`24`	`}`
`24`	`25`	`],`
`@@ -42,7 +43,8 @@`
`42`	`43`	`"short_name": "CLibraryFacilitiesNotAccessedThroughCPPLibraryHeaders",`
`43`	`44`	`"tags": [`
`44`	`45`	`"correctness",`
`45`		`- "readability"`
	`46`	`+ "readability",`
	`47`	`+ "scope/single-translation-unit"`
`46`	`48`	`]`
`47`	`49`	`}`
`48`	`50`	`],`
`@@ -65,7 +67,8 @@`
`65`	`67`	`"severity": "warning",`
`66`	`68`	`"short_name": "LocaleFunctionsUsed",`
`67`	`69`	`"tags": [`
`68`		`- "correctness"`
	`70`	`+ "correctness",`
	`71`	`+ "scope/single-translation-unit"`
`69`	`72`	`]`
`70`	`73`	`},`
`71`	`74`	`{`
`@@ -76,7 +79,8 @@`
`76`	`79`	`"severity": "warning",`
`77`	`80`	`"short_name": "LocaleMacrosUsed",`
`78`	`81`	`"tags": [`
`79`		`- "correctness"`
	`82`	`+ "correctness",`
	`83`	`+ "scope/single-translation-unit"`
`80`	`84`	`]`
`81`	`85`	`},`
`82`	`86`	`{`
`@@ -87,7 +91,8 @@`
`87`	`91`	`"severity": "warning",`
`88`	`92`	`"short_name": "LocaleTypeLConvUsed",`
`89`	`93`	`"tags": [`
`90`		`- "correctness"`
	`94`	`+ "correctness",`
	`95`	`+ "scope/single-translation-unit"`
`91`	`96`	`]`
`92`	`97`	`}`
`93`	`98`	`],`
`@@ -111,7 +116,8 @@`
`111`	`116`	`"short_name": "CsignalFunctionsUsed",`
`112`	`117`	`"tags": [`
`113`	`118`	`"maintainability",`
`114`		`- "correctness"`
	`119`	`+ "correctness",`
	`120`	`+ "scope/single-translation-unit"`
`115`	`121`	`]`
`116`	`122`	`},`
`117`	`123`	`{`
`@@ -123,7 +129,8 @@`
`123`	`129`	`"short_name": "CsignalTypesUsed",`
`124`	`130`	`"tags": [`
`125`	`131`	`"maintainability",`
`126`		`- "correctness"`
	`132`	`+ "correctness",`
	`133`	`+ "scope/single-translation-unit"`
`127`	`134`	`]`
`128`	`135`	`}`
`129`	`136`	`],`
`@@ -147,7 +154,8 @@`
`147`	`154`	`"short_name": "ErrnoUsed",`
`148`	`155`	`"tags": [`
`149`	`156`	`"correctness",`
`150`		`- "maintainability"`
	`157`	`+ "maintainability",`
	`158`	`+ "scope/single-translation-unit"`
`151`	`159`	`]`
`152`	`160`	`}`
`153`	`161`	`],`
`@@ -171,7 +179,8 @@`
`171`	`179`	`"short_name": "CstdioFunctionsUsed",`
`172`	`180`	`"tags": [`
`173`	`181`	`"maintainability",`
`174`		`- "correctness"`
	`182`	`+ "correctness",`
	`183`	`+ "scope/single-translation-unit"`
`175`	`184`	`]`
`176`	`185`	`},`
`177`	`186`	`{`
`@@ -183,7 +192,8 @@`
`183`	`192`	`"short_name": "CstdioMacrosUsed",`
`184`	`193`	`"tags": [`
`185`	`194`	`"maintainability",`
`186`		`- "correctness"`
	`195`	`+ "correctness",`
	`196`	`+ "scope/single-translation-unit"`
`187`	`197`	`]`
`188`	`198`	`},`
`189`	`199`	`{`
`@@ -195,7 +205,8 @@`
`195`	`205`	`"short_name": "CstdioTypesUsed",`
`196`	`206`	`"tags": [`
`197`	`207`	`"maintainability",`
`198`		`- "correctness"`
	`208`	`+ "correctness",`
	`209`	`+ "scope/single-translation-unit"`
`199`	`210`	`]`
`200`	`211`	`}`
`201`	`212`	`],`
`@@ -220,7 +231,8 @@`
`220`	`231`	`"short_name": "UsageOfAssemblerNotDocumented",`
`221`	`232`	`"tags": [`
`222`	`233`	`"readability",`
`223`		`- "maintainability"`
	`234`	`+ "maintainability",`
	`235`	`+ "scope/single-translation-unit"`
`224`	`236`	`]`
`225`	`237`	`}`
`226`	`238`	`],`