This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Update the generated .gitignore #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FurkanKambay
commented
Dec 28, 2018
shana
reviewed
Jan 8, 2019
|
This looks great, thank you so much! Sorry for the delay in the review, the holidays always get in the way... I did a couple of tweaks to your branch, everything looks great. As for the crashalytics line, I don't know what it is, but looking at examples like https://github.com/auth0/sharelock-android/blob/master/app/src/main/assets/crashlytics-build.properties on the internets, looks like it's something that shouldn't be committed to source control. It's not always in StreamingAssets though, so the ignore should probably just be the filename |
|
@shana No worries! And thanks for the other changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Updated the
.gitignorethat gets generated when initializing the repo. I copied from Unity.gitignore in github/gitignore.To go over the changes top-to-bottom:
.gitignoreis at the root of the repo anywayLogs/(Unity Logs github/gitignore#2912).gradle/([Unity] Ignore .gradle/ build cache github/gitignore#2906)*.opendb(Added *.opendb github/gitignore#2681)*.VC.db(Added *.VC.db to Unity.gitignore github/gitignore#2847)*.pdb.meta(Add Unity generated meta file for an already ignored debugging file github/gitignore#2486)Also there was another change about Crashlytics, but I didn't include it. Tell me if you want it.