Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Making the standalone api nicer to use #989

Merged
merged 9 commits into from
Jan 23, 2019
Merged

Making the standalone api nicer to use #989

merged 9 commits into from
Jan 23, 2019

Conversation

shana
Copy link
Member

@shana shana commented Dec 21, 2018

I did a little app (https://github.com/shana/unity-runtime-git) to test using the api at runtime, and I had to do some tweaks to make it nicer to use. These are those tweaks:

  • When parsing the history log, the first line of the commit was being added to the description. This makes it annoying to show entries when showing both the first line (summary) and the body (description), as the first line would appear duplicated. I kinda wanna treat these as email subject and body (because that's what they were meant to be originally in git anyways), so took out the duplication.
  • calling InitializeRepository(path to repository) on DefaultEnvironment does the useful thing of setting the base path on the FileSystem object, which means any shell commands and path manipulations are going to assume that path to repository as the base for all relative paths and working directory paths. Which is handy! Only the logic that we currently have makes it impossible to call InitializeRepository twice (it just ignores it), so it's not easy to switch these paths.
  • The task classes should be public, they're useful!

Copy link
Contributor

@StanleyGoldman StanleyGoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, otherwise one nit pick.

shana and others added 2 commits January 23, 2019 14:18
@StanleyGoldman StanleyGoldman merged commit 5defe7b into master Jan 23, 2019
@StanleyGoldman StanleyGoldman deleted the fixes/api branch January 23, 2019 13:26
@github-for-unity github-for-unity deleted a comment Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants