Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Fixing issues where the user has multiple connections #970

Merged
merged 6 commits into from
Dec 7, 2018

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Nov 28, 2018

Fixes #967

  • Authenticating with a token to GitHub Enterprise would result in the scheme and host address being stored in the keychain's host field. Whereas authenticating to GitHub would store only the host. The fix is to only store the host address as expected.
  • Getting the current username based off the keychain of the current repository's host, if such a keychain entry exists. If it exists and the username matches, allow the user to "Relase Lock", otherwise that option should be disabled or not visible.

@StanleyGoldman StanleyGoldman changed the title [WIP] Multiple connection issues Fixing issues where the user has multiple connections Nov 29, 2018
@StanleyGoldman StanleyGoldman requested a review from shana November 29, 2018 17:20
Copy link
Member

@shana shana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it :)

@StanleyGoldman StanleyGoldman merged commit a93cce1 into master Dec 7, 2018
@StanleyGoldman StanleyGoldman deleted the github-enterprise-host branch December 7, 2018 00:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues handling a repo on GitHub Enterprise with two connections in keychain
2 participants