Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Case insensitive usernames #958

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Case insensitive usernames #958

merged 2 commits into from
Nov 19, 2018

Conversation

StanleyGoldman
Copy link
Contributor

Fixes #957

  • Always use what the server replies for the username instead of what the user entered
  • Use a case insensitive match when comparing against the username for authentication

StanleyGoldman and others added 2 commits November 6, 2018 17:31
@StanleyGoldman @iAmWillShepherd
Always get the username from the Api because we have no idea what the…
94c4344 
… user gave us

Co-authored-by: iamwillshepherd <iamwillshepherd@users.noreply.github.com>
@StanleyGoldman @iAmWillShepherd
Ignore case when comparing username
6fc7964 
Co-authored-by: iamwillshepherd <iamwillshepherd@users.noreply.github.com>
@shana shana merged commit 6c9eee6 into master Nov 19, 2018
@shana shana deleted the fixes/username-case-insensitive branch November 19, 2018 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shana shana shana approved these changes

@iAmWillShepherd iAmWillShepherd Awaiting requested review from iAmWillShepherd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanleyGoldman @shana