Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Changing how zip extracted resources are moved to their destination #925

Merged
merged 10 commits into from
Oct 9, 2018

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Oct 4, 2018

Fixes #898
Fixes #836

This bug has appeared before in the past and we were never sure of the cause, but it seems to be a common enough setup for people to locate their "Temp" folder on something other than their user profile. When that is the case we cannot move the folder from one location to another, we have to actually create the folder and move the contents therein. I'm not able to reproduce this on my machine, but extensive user testing in #836 has resulted in this fix.

@StanleyGoldman StanleyGoldman requested a review from a team October 5, 2018 14:53
@StanleyGoldman StanleyGoldman changed the title Figuring out why octorun won't move Changing how zip extracted resouces are copied to their destination Oct 5, 2018
@StanleyGoldman StanleyGoldman changed the title Changing how zip extracted resouces are copied to their destination Changing how zip extracted resources are copied to their destination Oct 5, 2018
@StanleyGoldman StanleyGoldman changed the title Changing how zip extracted resources are copied to their destination Changing how zip extracted resources are moved to their destination Oct 5, 2018
@StanleyGoldman StanleyGoldman merged commit 93a1db6 into master Oct 9, 2018
@StanleyGoldman StanleyGoldman deleted the fixes/cannot-move-octorun branch October 9, 2018 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unzipped resources cannot be directly moved between drives Unzipped resources cannot be directly moved between drives
1 participant