Handling file names that look like they are a drive letter #921

StanleyGoldman · 2018-10-03T15:28:06Z

In a user's repo the file c:UsersOculusGoVideo.mp4 exists in history and trips up the log parsing process. The fix is being made in NPath (our IO library).

Unity/src/GitHub.Api/IO/NiceIO.cs

Lines 114 to 124 in 3a9593c

    
           private static string ParseDriveLetter(string path, out string driveLetter) 
        
           { 
        
               if (path.Length >= 3 && path[1] == ':' && (path[2] == '/' || path[2] == '\\')) 
        
               { 
        
                   driveLetter = path[0].ToString(); 
        
                   return path.Substring(2); 
        
               } 
        
               driveLetter = null; 
        
               return path; 
        
           }

Tests have been added to verify this case works.

Fixes: #922
Related to #899 - #899 (comment)

queerviolet

LG, like the tests 👍

queerviolet · 2018-10-04T01:45:29Z

src/tests/UnitTests/IO/GitObjectFactoryTests.cs

+            var gitObjectFactory = new GitObjectFactory(environment);
+            var gitStatusEntry = gitObjectFactory.CreateGitStatusEntry("c:UsersOculusGoVideo.mp4", GitFileStatus.Deleted);
+
+            Assert.AreEqual(@"c:\Projects\UnityProject\c:UsersOculusGoVideo.mp4", gitStatusEntry.FullPath);


WHO NAMES THEIR FILES THIS? 😂

StanleyGoldman added 3 commits October 3, 2018 11:23

Adding a test that proves the error

4b0769c

Fixing the issue

3a9593c

Cleanup

4b08403

StanleyGoldman added the ready-for-review label Oct 3, 2018

StanleyGoldman mentioned this pull request Oct 3, 2018

Cancelling invalidation of cache #923

Merged

1 task

StanleyGoldman requested review from daviwil, grokys, jcansdale and smashwilson October 3, 2018 18:21

StanleyGoldman mentioned this pull request Oct 3, 2018

After a certain number of changes, no changes are displayed locally #899

Closed

StanleyGoldman requested review from annthurium, queerviolet and drguthals October 3, 2018 20:22

StanleyGoldman mentioned this pull request Oct 3, 2018

"No Remote Configured" #895

Closed

queerviolet approved these changes Oct 4, 2018

View reviewed changes

StanleyGoldman merged commit 586de7a into master Oct 4, 2018

StanleyGoldman deleted the strange-file-names branch October 4, 2018 11:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Handling file names that look like they are a drive letter #921

Handling file names that look like they are a drive letter #921

Uh oh!

StanleyGoldman commented Oct 3, 2018 •

edited

Loading

Uh oh!

queerviolet left a comment

Uh oh!

queerviolet Oct 4, 2018

Uh oh!

StanleyGoldman Oct 4, 2018

Uh oh!

Uh oh!

	private static string ParseDriveLetter(string path, out string driveLetter)
	{
	if (path.Length >= 3 && path[1] == ':' && (path[2] == '/' \|\| path[2] == '\\'))
	{
	driveLetter = path[0].ToString();
	return path.Substring(2);
	}

	driveLetter = null;
	return path;
	}

Handling file names that look like they are a drive letter #921

Handling file names that look like they are a drive letter #921

Uh oh!

Conversation

StanleyGoldman commented Oct 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

queerviolet left a comment

Choose a reason for hiding this comment

Uh oh!

queerviolet Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

StanleyGoldman Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StanleyGoldman commented Oct 3, 2018 •

edited

Loading