Project Window Interface Fixes

[StanleyGoldman]

How did this ever work?

Correcting statement to check status of initialization

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs

Line 29 in 14bab1c

private static bool IsInitialized { get { return Repository != null && Repository.CurrentRemote.HasValue; } }

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs

Lines 38 to 43 in 14bab1c

	if (IsInitialized)
	{
	Repository.StatusEntriesChanged += RepositoryOnStatusEntriesChanged;
	Repository.LocksChanged += RepositoryOnLocksChanged;
	ValidateCachedData();
	}

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs

Lines 87 to 90 in 14bab1c

	private static bool ContextMenu_CanLock()
	{
	if (!EnsureInitialized())
	return false;

This issue occurs because IsInitialized is being used to hook up events and control data validation.
And is also being used to control the display of LFS menu items. So this logic needed to be separated out.

Fixes #910

Refreshing Asset database on Repository.StatusEntriesChanged

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs

Lines 65 to 70 in 7b7c5e5

	private static void RepositoryOnStatusEntriesChanged(CacheUpdateEvent cacheUpdateEvent)
	{
	if (!lastRepositoryStatusChangedEvent.Equals(cacheUpdateEvent))
	{
	lastRepositoryStatusChangedEvent = cacheUpdateEvent;
	AssetDatabase.Refresh();

Calling refresh here is needed to refresh the asset explorer window. Thanks to a hint from @oboka in #907.

Fixes #900
Fixes #882
Fixes #907

[shana]

This check is used to determine whether to show lock/unlock menus. If you're going to change this logic, you need to also fix how we enable those menus, because we can't lock/unlock if there's no remote.

[StanleyGoldman]

👍

🌴

[daviwil]

Looks like this should fix the comment @shana had! 👍