This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Make sure the correct environment variables are being read #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though environment variable keys are case-insensitive, they're exposed via a hashset that is case-sensitive. This means that in some cases, when the environment variable is named `Path` for eg, setting PATH=something causes a duplication of the keys Path/PATH, and the actual original environment variable that the system reads is not updated. WTF. This change looks up environment variables by a case insensitive search. It might fix #1044, since that problem is being caused by the wrong git being used in some operations, so I'm going to take a wild guess that maybe in those cases the wrong environment variable is getting read.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PossibleConfirmed fix for the wrong git being picked up in some cases. Fixes #1044Even though environment variable keys are case-insensitive, they're exposed via a hashset that is case-sensitive. This means that in some cases, for eg when the environment variable is named
Path, settingPATH=somethingcauses an additionalPATHenv var to be created, and the actual original environment variablePaththat the system reads is not updated. WTF.This change looks up environment variables by a case insensitive search. It might fix #1044, since that problem is being caused by the wrong git being used in some operations, so I'm going to take a wild guess that maybe in those cases the wrong environment variable is getting read.