This repository was archived by the owner on Dec 5, 2024. It is now read-only.
fix asmdef files giving errors on 2018.3 #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
approved these changes
Jan 18, 2019
There was a problem hiding this comment.
Yeah, it sucks a lot that they keep changing the format on this file. I'm fine with upping the required version for it to 2018.3. This is only for developing the extension itself and doesn't affect the actual build of it, and we should always probably track the latest Unity release so that we can incorporate new APIs into the shim as they become available.
shana
changed the base branch from
master
to
pr/1000-fix-asmdef-files-giving-errors-on-2018-3
shana
merged commit 9609f31
into
github-for-unity:pr/1000-fix-asmdef-files-giving-errors-on-2018-3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I've updated the .asmdef files so that you can do the quick debugging workflow using Unity 2018.3. Discussed this with Shana on Discord.
Benefits
This allows developers the quick iteration of loading the GUI code directly in Unity
Possible Drawbacks
Older versions of Unity will be broken