Octorun zip package from packaging script is invalid on Mac

[StanleyGoldman]

The zips created by the packaging script do not work correctly on macs. At least such is the case if the script is run on Windows. I have not tried to create the zip on a mac.

https://github.com/github-for-unity/Unity/raw/902910f4f32ff3ab412fe4adfb3928ed455c72cf/src/GitHub.Api/Resources/octorun.zip

181009-10:12:17.473  INFO [ 1] <Global>                            Initializing GitHubForUnity:'v1.1.0' Unity:'v5.6.0f3'
181009-10:12:17.512 TRACE [ 3] <DownloadTask>                      Download of http://github-vs.s3.amazonaws.com/unity/latest.json to /Users/sarahguthals/Library/Application Support/GitHubUnity/latest.json Attempt 1 of 1
181009-10:12:17.560 TRACE [ 2] <ProcessWrapper>                    Running 'bash -c "/usr/libexec/path_helper"'
181009-10:12:17.642 TRACE [ 3] <DownloadTask>                      Downloading http://github-vs.s3.amazonaws.com/unity/latest.json
181009-10:12:17.743 TRACE [ 2] <IApplicationManager>               Existing Environment Path Original:/usr/bin:/bin:/usr/sbin:/sbin Updated:PATH="/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/Racket v6.8/bin:/Applications/VMware Fusion.app/Contents/Public:/Library/TeX/texbin"; export PATH;

181009-10:12:17.760 TRACE [ 2] <UnzipTask>                         Unzip File: /Users/sarahguthals/Library/Application Support/GitHubUnity/downloads/octorun.zip to Path: /var/folders/tk/mrlhdh_9507_4_nz58bz3mjr0000gn/T/octorun_extract_archive_path_915679055
181009-10:12:17.813 TRACE [ 2] <OctorunInstaller>                  MoveOctorun fromPath: /var/folders/tk/mrlhdh_9507_4_nz58bz3mjr0000gn/T/octorun_extract_archive_path_915679055/octorun toPath:/Users/sarahguthals/Library/Application Support/GitHubUnity/octorun
181009-10:12:17.833 ERROR [ 2] <IApplicationManager>               A problem ocurred setting up Git
System.IO.DirectoryNotFoundException: Directory '/var/folders/tk/mrlhdh_9507_4_nz58bz3mjr0000gn/T/octorun_extract_archive_path_915679055/octorun' not found.
  at System.IO.Directory.GetFileSystemEntries (System.String path, System.String searchPattern, FileAttributes mask, FileAttributes attrs) [0x000f7] in /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.IO/Directory.cs:514 
  at System.IO.Directory.GetFiles (System.String path, System.String searchPattern) [0x00000] in /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.IO/Directory.cs:308 
  at GitHub.Unity.FileSystem.GetFiles (System.String path, System.String pattern) [0x00000] in C:\Users\Spade\Projects\GitHub\Unity\src\GitHub.Api\IO\FileSystem.cs:143 
  at GitHub.Unity.FileSystem+<GetFiles>c__Iterator0.MoveNext () [0x00027] in C:\Users\Spade\Projects\GitHub\Unity\src\GitHub.Api\IO\FileSystem.cs:148 
  at System.Linq.Enumerable+<CreateSelectIterator>c__Iterator10`2[System.String,GitHub.Unity.NPath].MoveNext () [0x00000] in <filename unknown>:0 
  at System.Linq.Enumerable+<CreateWhereIterator>c__Iterator1D`1[GitHub.Unity.NPath].MoveNext () [0x00000] in <filename unknown>:0 
  at System.Linq.Enumerable+<CreateSelectIterator>c__Iterator10`2[GitHub.Unity.NPath,GitHub.Unity.NPath].MoveNext () [0x00000] in <filename unknown>:0 
  at System.Collections.Generic.List`1[GitHub.Unity.NPath].AddEnumerable (IEnumerable`1 enumerable) [0x0001a] in /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Collections.Generic/List.cs:128 
  at System.Collections.Generic.List`1[GitHub.Unity.NPath]..ctor (IEnumerable`1 collection) [0x00025] in /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Collections.Generic/List.cs:65 
  at System.Linq.Enumerable.ToArray[NPath] (IEnumerable`1 source) [0x00000] in <filename unknown>:0 
  at GitHub.Unity.NPath.MoveFiles (NPath destination, Boolean recurse, System.Func`2 fileFilter) [0x00062] in C:\Users\Spade\Projects\GitHub\Unity\src\GitHub.Api\IO\NiceIO.cs:898 
  at GitHub.Unity.OctorunInstaller.MoveOctorun (NPath fromPath) [0x00049] in C:\Users\Spade\Projects\GitHub\Unity\src\GitHub.Api\Installer\OctorunInstaller.cs:59 
  at GitHub.Unity.OctorunInstaller.SetupOctorunIfNeeded () [0x0008f] in C:\Users\Spade\Projects\GitHub\Unity\src\GitHub.Api\Installer\OctorunInstaller.cs:43 
  at GitHub.Unity.ApplicationManagerBase.<Run>m__0 () [0x000fd] in C:\Users\Spade\Projects\GitHub\Unity\src\GitHub.Api\Application\ApplicationManagerBase.cs:92 
=======
   at GitHub.Unity.ApplicationManagerBase.<Run>m__0() in C:\Users\Spade\Projects\GitHub\Unity\src\GitHub.Api\Application\ApplicationManagerBase.cs:line 144
181009-10:12:17.926 TRACE [ 3] <DownloadTask>                      Downloading http://github-vs.s3.amazonaws.com/unity/latest.json StatusCode:200
181009-10:12:17.931 TRACE [ 3] <Global>                            Skipping GitHub for Unity update v1.0.3, we already have it
181009-10:12:20.321  INFO [ 1] <Global>                            Trace Logging Enabled
181009-10:12:20.350 TRACE [ 1] <UsageTracker>                      userId:7ce52939-6f20-4bb0-b4ff-5aeee4608473 instanceId:ff35fe3b-86fb-4b8d-9589-bbca3be0aa15
181009-10:12:20.371 TRACE [ 1] <RepositoryInfoCache>               needsInvalidation isInitialized:False timedOut:True
181009-10:12:20.389 TRACE [ 1] <GitStatusCache>                    needsInvalidation isInitialized:False timedOut:True
181009-10:12:20.390 TRACE [ 1] <GitLocksCache>                     needsInvalidation isInitialized:False timedOut:True

[StanleyGoldman]

@shana fixed this in #996