Skip to content

commit.committer.time is actually author time #82

Closed
@commonquail

Description

@commonquail

Describe the bug (required)

The commit.committer.time property gets populated with the commit authoring time, i.e. the same value as commit.author.time. This happens because both values use the same supplier, which COMMIT_COMMITTER_TIME clearly confirms was not the intention. This error has existed since the properties' introduction in v4.0.4.

Steps to Reproduce (required)

$ mvn package -P git-with-parent >/dev/null ; grep commit.*time target/classes/git.properties
git.commit.author.time=2019-08-25T20\:59\:43+0200
git.commit.committer.time=2019-08-25T20\:59\:43+0200
git.commit.time=2019-08-25T21\:03\:44+0200

with

diff --git a/pom.xml b/pom.xml
index b6fe073..3966f56 100644
--- a/pom.xml
+++ b/pom.xml
@@ -43,7 +43,7 @@
 		<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 		<java.target>1.8</java.target>
 		<!--<git-commit-id-version>2.2.5</git-commit-id-version> -->
-		<git-commit-id-version>3.0.0</git-commit-id-version>
+		<git-commit-id-version>4.0.4</git-commit-id-version>
 		<sonar.projectVersion>${project.version}-${git.branch}</sonar.projectVersion>
 	</properties>
 

applied to git-commit-id/git-commit-id-maven-debugging@beef4e9

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions