Skip to content

git.build.time cannot be excluded with excludeProperty #99

Closed
@TheSnoozer

Description

@TheSnoozer

Hi,
with version issue #91 or more readable version 2.1.9 of the maven-git-commit-id-plugin you introduced the ability to exclude properties.
Unfortunately I can not exclude the "git.build.time".
Example Configuration:
<plugin> <groupId>pl.project13.maven</groupId> <artifactId>git-commit-id-plugin</artifactId> <version>2.1.9</version> <executions> <execution> <phase>validate</phase> <goals> <goal>revision</goal> </goals> </execution> </executions> <configuration> <prefix>git</prefix> <dateFormat>dd.MM.yyyy '@' HH:mm:ss z</dateFormat> <verbose>false</verbose> <dotGitDirectory>${project.basedir}/../.git</dotGitDirectory> <skipPoms>true</skipPoms> <generateGitPropertiesFile>true</generateGitPropertiesFile> <generateGitPropertiesFilename>target/classes/git.properties</generateGitPropertiesFilename> <failOnNoGitDirectory>false</failOnNoGitDirectory> <excludeProperties> <excludeProperty>git.branch</excludeProperty> <excludeProperty>git.build.*</excludeProperty> <excludeProperty>git.build.time</excludeProperty> <excludeProperty>git.commit.user.*</excludeProperty> <excludeProperty>git.commit.message.*</excludeProperty> <excludeProperty>git.commit.time</excludeProperty> <excludeProperty>git.remote.origin.url</excludeProperty> </excludeProperties> <gitDescribe> <skip>false</skip> <always>true</always> <abbrev>8</abbrev> <forceLongFormat>false</forceLongFormat> </gitDescribe> </configuration> </plugin>

Resulting git.properties File looks like this:
``#Generated by Git-Commit-Id-Plugin

Wed Mar 05 10:17:28 CET 2014

git.commit.id.abbrev=.......
git.commit.id=......
git.commit.id.describe=......
git.build.time=.....``

Edit:
No pull request becasue I got to go, but I think the "Problem" is in the
GitCommitIdMojo.java LN 308 / 309, you actually have to swap filterNot and loadBuildTimeData to exclude BUILD_TIME as well (if the excludeproperty is set).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions