-
-
Notifications
You must be signed in to change notification settings - Fork 37
Added new attribute to provide factory function for additional buttons #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to provide custom buttons, instead of having to stringify a factory function. When both additionalButtons and "addExtraButtons" are provided, merge both buttons.
Would it be possible to fix the indentation? It's hard to see what you changed when the PR highlight almost everything has changed :( I think your editor is set to 2 but my code at that time was set to 4 spaces. |
No problem, I'll try to change it |
It seems it didn't work. I'll try again later so its easier to spot changes |
It might be Tabs not spaces, I used Sublime Text at that time, not sure what was set originally. If you can't get it to work, I can change my original indentation to 2 spaces. nowadays I'm using VSCode and follow the standard of 2 spaces. So anyway, I could change the indentation if that helps but you might have to redo the PR. Let me know what is best for you, and yes I asked you to change it because I can't see your code change when everything is red :P |
I think I got it right this time :D |
Yes I can see the changes now, thanks for that. Would you mind providing an example with your new |
Unfortunately you assumed wrong :P . I think i fixed it tho. |
Will have to close this PR since support of version However, if you still need to use it in |
Added a scope attribute, to be executed in the parent scope in order to provide custom buttons, instead of having to stringify a factory function.
When both additionalButtons and "addExtraButtons" are provided, merge both buttons.