Skip to content

vulkan: automatically deduce size of push constants #13936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vulkan: automatically deduce size of push constants #13936

wants to merge 1 commit into from

Conversation

jeffbolznv
Copy link
Collaborator

It was pointed out to me that ggml_vk_mul_mat_vec_nc_f16_f32 was passing the wrong size for the push constants. This change automatically deduces the size from the size of the struct/vector/array.

@jeffbolznv jeffbolznv requested a review from 0cc4m May 31, 2025 04:34
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0cc4m 0cc4m Awaiting requested review from 0cc4m

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeffbolznv