ggml-cpu : split arch-specific implementations #13892
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll need a bit more time to get this PR rebased onto the latest master branch. |
github-actions
bot
added
the
ggml
|
@ggerganov @slaren |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the arch-specific code organization, following the discussion in #13720. Key changes include splitting the former
ggml-cpu-quants.candggml-cpu-aarch64.cppinto several more focused files. Additionally,aarch64-related naming and identifiers, originally specific to AArch64 but now applicable to other architectures, have been updated to userepackto improve clarity and avoid confusion.