Skip to content

server: avoid overwriting Authorization header #10870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

vesath
Copy link
Contributor

@vesath vesath commented Dec 17, 2024

If no API key is set, leave the Authorization header as is. It may be used by another part of the Web stack, such as an authenticating proxy.

Fixes #10854

(This PR supersedes #10859 )

@ngxson
Copy link
Collaborator

ngxson commented Dec 17, 2024

You should create a PR from another branch in your fork, not the master branch. This way, I will be able to push a fix.

@vesath
Copy link
Contributor Author

vesath commented Dec 18, 2024

I was not aware there was anything else to fix but, as requested, here is a new pull request from a different branch: #10878

Cheers.

@ngxson
Copy link
Collaborator

ngxson commented Dec 18, 2024

Your index.html.gz was not correcly generated. I'll need to push the correct version in the other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc. bug: since 235f6e1 llama-server's main.js overwrites Authorization header so Web UI fails behind authenticating reverse proxy
2 participants