Skip to content

llama : integer type consistency in llama.h #4574

Open
@MarcusDunn

Description

@MarcusDunn

Feature Description

llama.h should prefer to use sized (always) + signed (mostly) integers.

Motivation

The integer types in llama.h right now are.

Count Type
33 int
10 int32_t
24 uint32_t
2 int64_t
2 uint64_t

In #4540 there was a discussion around preferences for integer types on new methods.

Avoiding int makes cross platform code simpler at essentially no cost.
Signed makes arithmetic simpler at the cost of some bits if you need something large.

Possible Implementation

  1. Change all int's to int32_t
  2. As code changes try to prefer signed integers.

We could also do some higher-impact things, but I'd take the lower-impact slower changes over a large find-and-replace.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions